----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41400/#review111745 -----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 76) <https://reviews.apache.org/r/41400/#comment171986> The same Comparator is present in PipelineInstanceDependencyTest. You should consider putting this in Utils, since multiple tests are anyway using this. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 147) <https://reviews.apache.org/r/41400/#comment171987> Use cleanTestsDirs(); (an existing function in BaseTestClass) instead of this. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLATest.java (line 74) <https://reviews.apache.org/r/41400/#comment171989> Add cleanTestDirs() here. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLATest.java (line 207) <https://reviews.apache.org/r/41400/#comment171993> Add this to Utils. It's a generic validation. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/ProcessSLATest.java (line 76) <https://reviews.apache.org/r/41400/#comment171995> Add cleanTestDirs() here falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/ProcessSLATest.java (line 166) <https://reviews.apache.org/r/41400/#comment171983> This is a generic method. Add it to Utils. - Karishma Gulati On Dec. 15, 2015, 2:48 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41400/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 2:48 p.m.) > > > Review request for Falcon and Ajay Yadava. > > > Bugs: FALCON-1566 > https://issues.apache.org/jira/browse/FALCON-1566 > > > Repository: falcon-git > > > Description > ------- > > Add test for SLA monitoring API > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > e406cae > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java > 55e862c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > ccd083b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java > 28ddbd7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessSLATest.java > f4c9b30 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLATest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/ProcessSLATest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41400/diff/ > > > Testing > ------- > > Tetsed in distributed mode. > > > Thanks, > > PRAGYA MITTAL > >
