----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41396/#review110859 -----------------------------------------------------------
webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java (line 133) <https://reviews.apache.org/r/41396/#comment170876> I don't think fully qualified name is required. Also, you should use lang3.StringUtils webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java (line 29) <https://reviews.apache.org/r/41396/#comment170882> The documentation is very terse. Please add detailed documentation for the class like it's purpose, where to use etc. webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java (line 37) <https://reviews.apache.org/r/41396/#comment170885> Detailed documentation please. - Ajay Yadava On Dec. 16, 2015, 4:39 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41396/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 4:39 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1635 > https://issues.apache.org/jira/browse/FALCON-1635 > > > Repository: falcon-git > > > Description > ------- > > In this jira, we migrate EntityManagerPaginationJerseyIT and > EntityManagerJerseySmokeIT using falcon unit. > > > Diffs > ----- > > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java > f5bcc54 > webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java > PRE-CREATION > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 258bb1a > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java > 2bedb88 > > webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java > 35119f0 > > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java > 7959b63 > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > f94bd8c > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 0697b3d > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 1d3167b > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 056c0a1 > > Diff: https://reviews.apache.org/r/41396/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
