> On Dec. 16, 2015, 5:24 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java, > > line 137 > > <https://reviews.apache.org/r/41396/diff/3/?file=1166571#file1166571line137> > > > > As part of falcon unit setup we should have already done this. Can you > > please check
Its required for the cluster mode. > On Dec. 16, 2015, 5:24 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java, > > line 134 > > <https://reviews.apache.org/r/41396/diff/3/?file=1166571#file1166571line134> > > > > Can't you use StringUtils in commons lang3. so that we can avoid > > package name here ? Will do it. > On Dec. 16, 2015, 5:24 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java, > > line 129 > > <https://reviews.apache.org/r/41396/diff/3/?file=1166574#file1166574line129> > > > > Can't we move createTestData to AbstractSchedulableManagerJerseyIT Makes sense. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41396/#review110680 ----------------------------------------------------------- On Dec. 16, 2015, 4:39 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41396/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 4:39 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1635 > https://issues.apache.org/jira/browse/FALCON-1635 > > > Repository: falcon-git > > > Description > ------- > > In this jira, we migrate EntityManagerPaginationJerseyIT and > EntityManagerJerseySmokeIT using falcon unit. > > > Diffs > ----- > > > webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java > f5bcc54 > webapp/src/test/java/org/apache/falcon/resource/AbstractTestContext.java > PRE-CREATION > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 258bb1a > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseySmokeIT.java > 2bedb88 > > webapp/src/test/java/org/apache/falcon/resource/EntitySchedulerManagerJerseyIT.java > 35119f0 > > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java > 7959b63 > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > f94bd8c > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 0697b3d > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 1d3167b > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 056c0a1 > > Diff: https://reviews.apache.org/r/41396/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
