> On Jan. 5, 2016, 5:12 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 64 > > <https://reviews.apache.org/r/41601/diff/4/?file=1176051#file1176051line64> > > > > Shouldn't this be just one ENTITY_TYPE_OPT with value being > > feed/process?
>From the CLI user will provide whether provided entity name is of type feed or >process and internally assigned both these schedulable entities to one >variable "schedEntityType". > On Jan. 5, 2016, 5:12 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 87 > > <https://reviews.apache.org/r/41601/diff/4/?file=1176051#file1176051line87> > > > > can we use the same parameter for specifying limit as in other api? I > > believe it's called numResults Fixed. > On Jan. 5, 2016, 5:12 a.m., Ajay Yadava wrote: > > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java, > > line 75 > > <https://reviews.apache.org/r/41601/diff/4/?file=1176056#file1176056line75> > > > > It will be really useful to have a time based filter (start, end) based > > on the instance time. This is not in the current scope but will look into it to provide later. I will create a JIRA issue for this. > On Jan. 5, 2016, 5:12 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 626 > > <https://reviews.apache.org/r/41601/diff/4/?file=1176053#file1176053line626> > > > > Please create another method instead of using a common method like > > sendMetadataDiscoveryRequest. Disadvantage in this approach is that with > > every parameter or new api (e.g. in this case schedEntityType) you will end > > up affecting other api calls and it will be a long list of parameters. I have not created another method as I am of the opinion to align with existing metadiscovry List API. And I don't think so that it will impact other API call's. Also sendMetadataDiscoveryRequest API should be refactorred in the Metadiscovery List and Relations API separately. > On Jan. 5, 2016, 5:12 a.m., Ajay Yadava wrote: > > docs/src/site/twiki/FalconCLI.twiki, line 482 > > <https://reviews.apache.org/r/41601/diff/4/?file=1176055#file1176055line482> > > > > There should be entity type, entity name and the no argument option > > -replicationMetrics. This will make the call more consistent with other api > > calls as type everywhere else is used for entity type. Metadiscovery list api supports following type: [cluster_entity|feed_entity|process_entity|user|colo|tags|groups|pipelines], so I have extend this by adding new type. I will rename to "replication_metrics". > On Jan. 5, 2016, 5:12 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/metadata/RelationshipType.java, line > > 43 > > <https://reviews.apache.org/r/41601/diff/4/?file=1176054#file1176054line43> > > > > metrics is very generic and doesn't convey the purpose of the api. Can > > we please make it more specific like replication-metrics or something? Fixed. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41601/#review112763 ----------------------------------------------------------- On Dec. 24, 2015, 7:58 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41601/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 7:58 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1643 > https://issues.apache.org/jira/browse/FALCON-1643 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1643 : Add CLI option to display captured replication metrics > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230a > client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java 36dd613 > client/src/main/java/org/apache/falcon/client/FalconClient.java aea39a6 > client/src/main/java/org/apache/falcon/metadata/RelationshipType.java > 8e5f8ea > docs/src/site/twiki/FalconCLI.twiki 26e6b33 > > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java > 60c1089 > > prism/src/test/java/org/apache/falcon/resource/metadata/LineageMetadataResourceTest.java > fb4ff6f > > prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java > 84ada9a > > prism/src/test/java/org/apache/falcon/resource/metadata/MetadataTestContext.java > 05cc2e9 > > Diff: https://reviews.apache.org/r/41601/diff/ > > > Testing > ------- > > Unit test cased added. Yes. > > > Thanks, > > Peeyush Bishnoi > >
