----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41601/#review113323 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java (line 162) <https://reviews.apache.org/r/41601/#comment173862> This line is repeated and can be outside if-else block client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java (line 249) <https://reviews.apache.org/r/41601/#comment173865> Please use StringUtils.isNotBlank() client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java (line 253) <https://reviews.apache.org/r/41601/#comment173864> It is better to use StringUtils.isNotBlank() method instead. client/src/main/java/org/apache/falcon/client/FalconClient.java (line 242) <https://reviews.apache.org/r/41601/#comment173860> If you are listing replication metrics, then this operation is not necessary. You should handle it as part of the LIST operation. prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java (line 108) <https://reviews.apache.org/r/41601/#comment173866> replication-metrics is the {type} in listDimensionValues method above, it is not needed to write a separate method here. - Balu Vellanki On Jan. 7, 2016, 6:23 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41601/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 6:23 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1643 > https://issues.apache.org/jira/browse/FALCON-1643 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1643 : Add CLI option to display captured replication metrics > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 24f230a > client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java 36dd613 > client/src/main/java/org/apache/falcon/client/FalconClient.java aea39a6 > client/src/main/java/org/apache/falcon/metadata/RelationshipType.java > 8e5f8ea > docs/src/site/twiki/FalconCLI.twiki 26e6b33 > > prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java > 60c1089 > > prism/src/test/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResourceTest.java > 84ada9a > > prism/src/test/java/org/apache/falcon/resource/metadata/MetadataTestContext.java > 05cc2e9 > > Diff: https://reviews.apache.org/r/41601/diff/ > > > Testing > ------- > > Unit test cased added. Yes. > > > Thanks, > > Peeyush Bishnoi > >
