----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41978/#review113191 -----------------------------------------------------------
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java (line 71) <https://reviews.apache.org/r/41978/#comment173680> Nit : Believe some of this is already being done in the base class, can't we just invoke a method on the base class? - Pallavi Rao On Jan. 6, 2016, 2:40 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41978/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 2:40 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1678 > https://issues.apache.org/jira/browse/FALCON-1678 > > > Repository: falcon-git > > > Description > ------- > > SLA Monitoring does not honour entity end date > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd > common/src/main/java/org/apache/falcon/util/DeploymentProperties.java > 715b7ba > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 1cd571e > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java > e3dd5cc > > Diff: https://reviews.apache.org/r/41978/diff/ > > > Testing > ------- > > Added unit tests for main and helper methods. > > > Thanks, > > Ajay Yadava > >
