> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 344 > > <https://reviews.apache.org/r/41978/diff/2/?file=1186384#file1186384line344> > > > > If entity end time is over why we are not calling onRemove(entity) on > > that ? > > Ajay Yadava wrote: > Good Question. If we do that then there is a risk of loosing the sla > monitoring for last few instances. In this case we just don't want to add any > instances after end date and monitoring for other instances should continue.
Ok undertsand, but atleast after some time we should remove these entities from the list right ? - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41978/#review113409 ----------------------------------------------------------- On Jan. 8, 2016, 10:57 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41978/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 10:57 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1678 > https://issues.apache.org/jira/browse/FALCON-1678 > > > Repository: falcon-git > > > Description > ------- > > SLA Monitoring does not honour entity end date > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 150e0bd > common/src/main/java/org/apache/falcon/util/DeploymentProperties.java > 715b7ba > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 9841083 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > 1cd571e > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java > e3dd5cc > > Diff: https://reviews.apache.org/r/41978/diff/ > > > Testing > ------- > > Added unit tests for main and helper methods. > > > Thanks, > > Ajay Yadava > >
