[
https://issues.apache.org/jira/browse/FALCON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782088#comment-13782088
]
Srikanth Sundarrajan commented on FALCON-133:
---------------------------------------------
Thanks for meticulously fixing all the loggers. I guess the following warn
message got accidentally left out. Can you please check.
{code}
@@ -236,7 +236,7 @@ public class FeedEvictor extends Configured implements Tool
{
if (ordinal++ == var.ordinal()) {
date += map.get(var);
} else {
- LOG.warn("Prior element to " + var + " is missing " + errArg);
+ LOGGER.warn("Prior element to " + var + " is missing " +
errArg);
return null;
}
}
{code}
Few more issues that need to be taken care of before we remove the direct
dependency on log4j
# Nested diagnostic context is being used in BasicAuthFilter
# NDC again being used in APIResult
# Remove log4j from dependencyManagement section in main pom
# Documentation (comment) in LoggingPlugin.java needs fix
Besides, can you check this as well?
{quote}
Hi Srikanth, let me check about the potential break, but I don't think so. I
double check.
{quote}
> Upgrade to slf4j 1.7.5 and use SLF4J logger
> -------------------------------------------
>
> Key: FALCON-133
> URL: https://issues.apache.org/jira/browse/FALCON-133
> Project: Falcon
> Issue Type: Improvement
> Components: general
> Reporter: Jean-Baptiste Onofré
> Fix For: 0.4
>
> Attachments: FALCON-133.patch
>
>
> SLF4J 1.7.5 provides interesting performance improvements.
> More over, it's not more require to test the log level, we can use directly
> {} in the message formatter.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
