[
https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107603#comment-14107603
]
Venkatesh Seetharam commented on FALCON-166:
--------------------------------------------
Few comments:
* isnt this a bad side-effect?
{code}else if (clusterStartEndDates.second != null &&
startDate.after(clusterStartEndDates.second)) {
startDate = clusterStartEndDates.second;
{code}
This should skip this cluster IMO, no?
* getEndDate - frequency can never be null
* getFrequencyAsInt - should it not be long?
* use constants for 10*60000, 10*3600000, etc.
* // default set endDate to be one day after startDate
+ endMillisecs += 86400000;
If the frequency is 1 min, then this is pretty bad. This is not necessary since
frequency is mandatory in the entity.
* getEntityStartEndDates - why should you compute this across all clusters, we
only need it for a given cluster no?
OK, since this is entity list and not summary, makes sense but how will Oozie
work when a particular cluster does not start at this computed start but
somewhere later?
> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>
> Key: FALCON-166
> URL: https://issues.apache.org/jira/browse/FALCON-166
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.3
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Fix For: 0.6
>
> Attachments: Falcon-Jira-166.patch
>
>
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while
> working on FALCON-164. The use case is to get the status for a given entity
> for the past 1 or 2 or 3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the
> start date which is too small a window.
> {code}
> private Date getEndDate(Date start, String endStr) throws FalconException
> {
> Date end;
> if (StringUtils.isEmpty(endStr)) {
> end = new Date(start.getTime() + 1000); // next sec
> } else {
> end = EntityUtil.parseDateUTC(endStr);
> }
> return end;
> }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date
> for looking at the instances in the past 7 days, it should fetch what is
> valid rather than complain that the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure
> what the performance impact is for this API to be changed.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
