[
https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108442#comment-14108442
]
Balu Vellanki commented on FALCON-166:
--------------------------------------
[~ajayyadava]
End date is not a required parameter. It is defaulted to min of (StartDate +
10*Frequency) or entityEndDate. We do not recommend default to now because
- if the start date is way in the past, setting default end date to now might
make query to the workflow scheduler expensive.
- If the end date calculated above is in future, it should not be changed to
now. This is because user might want to get list scheduled instances as well.
Start date - Your suggestion makes sense to me.
The current API along with pagination implemented in JIRA 470 allows user to
easily get N instances of an entity ordered by
"startTime","endTime","cluster". The default order for starttime and endtime
will be "descending". Should we provide an extra param, so that user can
specify if order is asc or desc?
I will wait for more comments before making changes to the code.
> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>
> Key: FALCON-166
> URL: https://issues.apache.org/jira/browse/FALCON-166
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.3
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Fix For: 0.6
>
> Attachments: Falcon-Jira-166-v1.patch, Falcon-Jira-166.patch
>
>
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while
> working on FALCON-164. The use case is to get the status for a given entity
> for the past 1 or 2 or 3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the
> start date which is too small a window.
> {code}
> private Date getEndDate(Date start, String endStr) throws FalconException
> {
> Date end;
> if (StringUtils.isEmpty(endStr)) {
> end = new Date(start.getTime() + 1000); // next sec
> } else {
> end = EntityUtil.parseDateUTC(endStr);
> }
> return end;
> }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date
> for looking at the instances in the past 7 days, it should fetch what is
> valid rather than complain that the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure
> what the performance impact is for this API to be changed.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
