[ 
https://issues.apache.org/jira/browse/FALCON-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112896#comment-14112896
 ] 

Venkatesh Seetharam commented on FALCON-325:
--------------------------------------------

Minor nits:

RelationshipProperty
WORKFLOW_STATUS("status" => workflowStatus

RelationshipLabel
    INSTANCE_WORKFLOW_GENEARTE_EDGE("generate-workflow-executed"),
    INSTANCE_WORKFLOW_REPLICATE_EDGE("replicate -workflow-executed"),
Why do we need for GENERATE?
Edge can we replication-policy or eviction-policy

InstanceRelationshipGraphBuilder
addProcessInstance
        Vertex wfInstance = addWorkflowInstance(context);
        addInstanceToWorkflow(processInstance, wfInstance, 
RelationshipLabel.INSTANCE_WORKFLOW_GENEARTE_EDGE);
This is NOT necessary since there will always be a 1-1 relationship between 
Process and Workflow, no?

addReplicatedInstance
Why is there a need for a *for* loop? Its a pair of clusters, pair of feed 
instances, no?
feedInstanceName and feedInstanceVertex should be the same.


> Process lineage information for Replication policies
> ----------------------------------------------------
>
>                 Key: FALCON-325
>                 URL: https://issues.apache.org/jira/browse/FALCON-325
>             Project: Falcon
>          Issue Type: Sub-task
>    Affects Versions: 0.5
>            Reporter: Venkatesh Seetharam
>            Assignee: Sowmya Ramesh
>              Labels: lineage
>             Fix For: 0.6
>
>         Attachments: FALCON-325.patch, FALCON-325.v1.patch
>
>
> The current patch only addresses process executions and not data lifecycle 
> policies. This task should address adding this information.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to