[ https://issues.apache.org/jira/browse/FALCON-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262227#comment-14262227 ]
Srikanth Sundarrajan commented on FALCON-237: --------------------------------------------- Setting static variables this way isn't thread safe, can lead to issues. {code} - public static final String SUCCEEDED_FILE_NAME = "_SUCCESS"; + public static String SUCCEEDED_FILE_NAME = "_SUCCESS"; ... + public static void setSucceededFileName(String succeededFileName) { + SUCCEEDED_FILE_NAME = succeededFileName; + } {code} Can you revised patch in review board. It will be easy to comment on the proposed changes. > falcon feed replication should honour availability flag > ------------------------------------------------------- > > Key: FALCON-237 > URL: https://issues.apache.org/jira/browse/FALCON-237 > Project: Falcon > Issue Type: Bug > Components: replication > Reporter: Binish A.R > Assignee: Peeyush Bishnoi > Fix For: 0.7 > > Attachments: FALCON-237.patch, FALCON-237.v2.patch > > > falcon feed replication does not honour availability flag defined in feed > definition while replicating feeds. As of now, the flag _SUCCESS is hardcoded > and is manually created at destination once the replication is done. > It should instead set the flag appropriately, as defined in the feed > definition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)