Clement Escoffier wrote:
-----Message d'origine-----
De : Stefano Lenzi [mailto:[EMAIL PROTECTED]
[cut]
Stuart McCulloch wrote:
On 14/09/2007, Stefano Lenzi <[EMAIL PROTECTED]> wrote:
Clement Escoffier wrote:
-----Message d'origine-----
De : Stefano Lenzi
[cut]
So I will vote for adding the bundle goal provided by your plugin
into
the official maven-bundle-plugin during the install phase of the
livecycle (maybe we can add an option to enable/disable such
feature)!
And I'll be happy to move your plugin in the trunk!
What do you think?
Yes, it could be great. The deploy goal is a cool feature too. But
as
for
the install goal, we need to add an option to enable/disable this
behavior.
I have just added the disableAutoInstall option in
maven-obr-plugin:repository goal as flag for enable/disable the
goal.
Would an 'installOBR' or 'installToOBR' flag be clearer? I think it
should
at least mention OBR in the name.
Also imho the default should be to not install to OBR, as that's the
current
(expected?) behaviour... wdyt?
I partially agree, I'll change it the 'disableAutoInstall' to
'installToLocalOBR' but I think that the default behavior should be to
install the bundle in a local repository.
IMO, installing in the local OBR can be enabled by default. It just create
the repository file locally, so it is not a problem. However, for the deploy
goal the problem is more complex. It creates an OBR file at the root of the
remote maven repository. In this case, it should be disabled by default.
I agree with your vision. In fact my original idea was to add only the
maven-obr-plugin:repository goal to the maven-bundle-plugin and to do
not add the maven-obr-plugin:deployment goal.
BTW, I think that we can add even the deployment goal and we should
investigate how to avoid race-condition on the remote OBR repository side.
Ciao,
Stefano "Kismet" Lenzi
