Rob Walker wrote:

I think, the method should rather gather all enumerations and returned a
combined enumeration over all results ...

WDYT ?

Seems fine - my only comments from a quick re-read of the spec for Bundle.getResources would be to ensure we observe restrictions:

   * If the bundle state is INSTALLED - only it's own local resources
     should be searched and returned
   * If the state is RESOLVED or above - only imported packages in
     addition to local ones should be searched

Currently, it seems that we always try to resolve the module (trying to be in the RESOLVED state). if there is an issue somewhere, there will be an Exception and we will only look into local resources.

# comment
At this point, no boot-delegation packages are tried to search the resource. Is this OK ?
# /comment

If the bundle is RESOLVED, then we try to load the resources in this order :
1. bootdelegation packages
2. modules imports
3. local resources
4. dynamic import

When you say that only imported packages (in addition to the local ones) should be seached, you exclude dynamic imported packages ?

Regards
--Guillaume



I'd guess our current approach does observe these - but just exits early on a first hit, and doesn't continue into imported packages.

-- Rob



Reply via email to