Richard S. Hall wrote:
Guillaume Sauthier wrote:
After a bit of digging, instead of using a Factory, with a Java5 compiled ContentClassLoader, that add a lot of burden (I know, I've tried that :) ), maybe it could be easier and more elegant to simply have the ContentClassLoader.findResources(String) method implemented using the ISearchPolicy to find the resources instead of just asking the IContentLoader for local resources.

BTW, this scenario will work if the R4SearchPolicyCore return a compund enumeration of ALL the found resources.

That might work, assuming we make the modification that Felix mentioned to aggregate all enumerations.
I'm working on that :)
I will submit a patch shortly.

BTW, I've got a couple of questions:
1. In R4SearchPolicyCore.findResources(String), when traversing the boot delegation packages, you placed the following comment:
// If this is a java.* package, then always terminate the
// search; otherwise, continue to look locally if not found.

Do we have to respect this with the compound enumeration ?
So far, I don't think so, nobody export java.* packages...

2. At the end, you throw a ResourceNotFoundException, if the 'urls' variable is null.
Is this still needed ?
BTW, I'm not at all sure that it was working correctly, because 'urls' may have been assigned to null by only the last IWire.getResources()

Thanks
--Guillaume

-> richard


Thanks
--Guillaume



Reply via email to