[
https://issues.apache.org/jira/browse/FELIX-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713027#action_12713027
]
Sahoo commented on FELIX-1179:
------------------------------
Filippo,
I had the similar idea when I submitted the bug and I was waiting for Richard
to apply patch to 1174 before uploading a patch. Thanks for making a patch and
test case available. There are two questions that come to my mind:
1. Should we optimize it for files with .jar extension? Probably not.
2. Should we close() the JarFile instead of waiting for finalizer() to do so? I
am not sure if just constructing a new JarFile locks any resource, but closing
would not hurt.
Thanks,
Sahoo
> FileInstall should recognize Jar files by content instead of extension
> ----------------------------------------------------------------------
>
> Key: FELIX-1179
> URL: https://issues.apache.org/jira/browse/FELIX-1179
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Affects Versions: fileinstall-1.0.0
> Environment: generic
> Reporter: Sahoo
> Fix For: fileinstall-1.2.0
>
> Attachments: FELIX-1179.txt
>
>
> Currently FileInstall recognizes files of two types: .cfg files and .jar
> files. I know there is already a request to have a plugin mechanism in
> FileInstall to support different kinds of file types, but that's more of a
> long term change. In short term, we can modify fileinstall to recognize Jar
> files by their content instead of going by just file extensions. It will
> allow us to use files like .war files in watched dir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
