[
https://issues.apache.org/jira/browse/FELIX-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Filippo Diotalevi updated FELIX-1179:
-------------------------------------
Attachment: FELIX-1179-2.txt
> 1. Should we optimize it for files with .jar extension?
The purpose is to install bundle with other extensions, so, I'd say, no.
> 2. Should we close() the JarFile instead of waiting for finalizer() to do so?
> I am not sure if just constructing a new
> JarFile locks any resource, but closing would not hurt.
Attached a second patch that closes the JarFile
> FileInstall should recognize Jar files by content instead of extension
> ----------------------------------------------------------------------
>
> Key: FELIX-1179
> URL: https://issues.apache.org/jira/browse/FELIX-1179
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Affects Versions: fileinstall-1.0.0
> Environment: generic
> Reporter: Sahoo
> Fix For: fileinstall-1.2.0
>
> Attachments: FELIX-1179-2.txt, FELIX-1179.txt
>
>
> Currently FileInstall recognizes files of two types: .cfg files and .jar
> files. I know there is already a request to have a plugin mechanism in
> FileInstall to support different kinds of file types, but that's more of a
> long term change. In short term, we can modify fileinstall to recognize Jar
> files by their content instead of going by just file extensions. It will
> allow us to use files like .war files in watched dir.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
