[
https://issues.apache.org/jira/browse/FELIX-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745235#action_12745235
]
Guillaume Nodet commented on FELIX-1505:
----------------------------------------
For tests that look like:
assertEquals("a", c.execute("e = { echo $0 } ; <e a b | capture>"));
This comes from me forgetting about the priority between | and ; so those can
be removed.
For the testClosure(), I think there is an intent here, though I'm not exactly
sure what it is supposed to test.
In the patch for FELIX-1471, I think I've changed this to
assertEquals("3", c.execute("[a=2 $(echo b)=$(echo 3)] get b").toString());
as my assumption was that the test tries to make sure things inside the array
are evaluated as well.
> [gogo] TestParser contains some unnecessary use of <>
> -----------------------------------------------------
>
> Key: FELIX-1505
> URL: https://issues.apache.org/jira/browse/FELIX-1505
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Derek Baum
> Priority: Minor
>
> TestParser contains some unnecessary use of <>.
> This is a problem as we are discussing changing how <> are handled and this
> will cause unnecessary test failures.
> It would be useful to review and cleanup TestParser before we embark on other
> changes.
> testClosure() is the worst offender:
> assertEquals("3", c.execute("[a=2 <b>=<3>] get b").toString());
> 6 like this:
> assertEquals("a", c.execute("e = { echo $0 } ; <e a b | capture>"));
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
