[
https://issues.apache.org/jira/browse/FELIX-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Derek Baum updated FELIX-1505:
------------------------------
Attachment: FELIX-1505.patch
the attached patch cleans up the existing TestParser:
remove extraneous use of <>:
"<echoout a b | capture>" becomes simply "echoout a b | capture"
remove extraneous use of capture:
"echo a b | capture" becomes simply "echo a b" (capture is only required to
capture stdout).
The odd test in testClosure:
assertEquals("3", c.execute("[a=2 <b>=<3>] get b").toString());
becomes:
assertEquals("3", c.execute("[a=2 b=3] get b").toString());
and I've added the original odd test to testFunny():
assertEquals("3", c.execute("[a=2 <b>=<3>] get b").toString());
I have not changed any of the test expected results in this patch.
> [gogo] TestParser contains some unnecessary use of <>
> -----------------------------------------------------
>
> Key: FELIX-1505
> URL: https://issues.apache.org/jira/browse/FELIX-1505
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Derek Baum
> Priority: Minor
> Attachments: FELIX-1505.patch
>
>
> TestParser contains some unnecessary use of <>.
> This is a problem as we are discussing changing how <> are handled and this
> will cause unnecessary test failures.
> It would be useful to review and cleanup TestParser before we embark on other
> changes.
> testClosure() is the worst offender:
> assertEquals("3", c.execute("[a=2 <b>=<3>] get b").toString());
> 6 like this:
> assertEquals("a", c.execute("e = { echo $0 } ; <e a b | capture>"));
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
