[
https://issues.apache.org/jira/browse/FELIX-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405811#comment-13405811
]
Dan Gravell commented on FELIX-3566:
------------------------------------
Not sure who should be reviewing it (!) but from a functional point of view
that looks good. It saves me a bit of code anyway.
>From a code point of view, it might be best to make sure line wrapping
>settings are the same, as localResource.getBundle().update[...] line is now
>wrapped. Might just be me but I don't like checking changes in that are
>immaterial...
Also, you could inline:
Bundle[] bundles = (Bundle[]) refreshList.toArray(new
Bundle[refreshList.size()]);
As bundles isn't used elsewhere in that scope. Maybe you meant to add them to
the log(Logger.LOG_WARNING, [...]) ? Might be useful.
> OBR should perform a refreshPackages after deploy
> -------------------------------------------------
>
> Key: FELIX-3566
> URL: https://issues.apache.org/jira/browse/FELIX-3566
> Project: Felix
> Issue Type: Improvement
> Components: Bundle Repository (OBR)
> Affects Versions: bundlerepository-1.6.6
> Reporter: Dan Gravell
> Priority: Minor
> Attachments: FELIX-3566.txt
>
>
> After invoking deploy() in a Resolver, perhaps the OBR should perform a
> refreshPackages so that the OSGi runtime clears out any old, un-needed
> bundles.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
