[
https://issues.apache.org/jira/browse/FELIX-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687832#comment-13687832
]
Felix Meschberger commented on FELIX-4137:
------------------------------------------
Thanks for providing the patch. Looks pretty good and quite simple. I
particularly like the context path exclusion part.
Yet, I have a few comments and suggestions for improvement:
* Only support the standard Web-ContextPath header to identify WAB bundles (it
looks like the other header is for backwards compatibility of the Pax Web
implementation)
* Maybe the deployment management could be moved to the JettyService class.
This would also provide access to the JettyConfig and thus allow configuration
of the path exclusion
* Path exclusion should probably implicitly include the context path used by
the Http Service implementation context
* Fully implement the Web Application Bundle (128.3), Events (128.5),
Interaction with the OSGi Environment (128.6.1) chapters. The Web URL Handler
(128.4.) chapter can probably be ignored for now.
* Resource access through the ServletContext: Make sure resources are loaded as
defined by the spec.
* As for the class loader I suggest to overwrite the loadClass, getResource,
and getResources methods instead of the find* methods to fully control the
class loading by first inspecting the wab bundle and then the Jetty bundle.
> Web application bundle (WAB) deployment
> ---------------------------------------
>
> Key: FELIX-4137
> URL: https://issues.apache.org/jira/browse/FELIX-4137
> Project: Felix
> Issue Type: New Feature
> Components: HTTP Service
> Affects Versions: http-2.2.0
> Reporter: Dominique Pfister
> Attachments: FELIX-4137.txt
>
>
> Support WAB deployment: if a bundle has a header "Web-ContextPath" or
> "Webapp-Context", deploy it inside the jetty servlet container under that
> servlet context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
