[
https://issues.apache.org/jira/browse/FELIX-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689452#comment-13689452
]
Dominique Pfister commented on FELIX-4137:
------------------------------------------
Thanks, Felix, for your comments! I implemented your suggestions in attached
patch (version 2):
* Only support the standard Web-ContextPath header to identify WAB bundles
- done
* Maybe the deployment management could be moved to the JettyService class.
This would also provide access to the JettyConfig and thus allow configuration
of the path exclusion
- done: the JettyActivator class has no more modifications
* Fully implement the Web Application Bundle (128.3), Events (128.5),
Interaction with the OSGi Environment (128.6.1) chapters. The Web URL Handler
(128.4.) chapter can probably be ignored for now.
- done
* Resource access through the ServletContext: Make sure resources are loaded as
defined by the spec.
- done
* As for the class loader I suggest to overwrite the loadClass, getResource,
and getResources methods instead of the find* methods to fully control the
class loading by first inspecting the wab bundle and then the Jetty bundle.
- I changed the ClassLoader as follows: the Jetty bundle class loader is used
as parent loader, and all the find* methods just look inside the wab bundle.
This way, the class loader will only ever load the wab bundle's classes and
resources, which seems appropriate.
> Web application bundle (WAB) deployment
> ---------------------------------------
>
> Key: FELIX-4137
> URL: https://issues.apache.org/jira/browse/FELIX-4137
> Project: Felix
> Issue Type: New Feature
> Components: HTTP Service
> Affects Versions: http-2.2.0
> Reporter: Dominique Pfister
> Attachments: FELIX-4137.2.txt, FELIX-4137.txt
>
>
> Support WAB deployment: if a bundle has a header "Web-ContextPath" or
> "Webapp-Context", deploy it inside the jetty servlet container under that
> servlet context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
