[
https://issues.apache.org/jira/browse/FELIX-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052826#comment-14052826
]
Chetan Mehrotra edited comment on FELIX-4550 at 7/5/14 9:16 AM:
----------------------------------------------------------------
[patch|^FELIX-4550.patch] for the same. Following are some key points wrt patch
* Upgrade Jetty to 9.2.1.v20140609
* Changed the source and target compiler settings for jetty module to 1.7
* Updated the Servlet API to tomcat-servlet-api:8.0.9 to include 3.1. The
org.apache.felix.http.servlet-api bundle now also export Servlet API at 3.1
* Some classes which implement servlet api modified to support new method
** SSLFilterResponseTest
** ServletContextImpl
** ServletContextImplTest
* FilterHandler - Had to change the if condition in doHandle as by default
jetty does not set status to 200 at start
([commit|http://dev.eclipse.org/mhonarc/lists/jetty-commit/msg05356.html]).
Upto Jetty 8.x this was set to 200 at start of request itself but now it is
being set at time of commit. Further the [Servet
API|http://download.oracle.com/javaee/6/api/javax/servlet/http/HttpServletResponse.html#getStatus%28%29]
does not say anything about the status code value
* JettyService - The way jetty get configured now change quite a bit. Most of
the previous config are mapped to new methods. One thing left out was making
JMX registration configurable. Currently JMX reg would be done always
*Non Compatible Change*
* Jetty 9 requires JDK 7
* ConnectorFactory - Need to change the method createConnector() to
createConnector(Server) as all Connector now require Server as part of
Constructor argument. Anyways as the Connector classes itself have changed in
non compatible way existing impls would not work
With this patch all existing test case pass. Also tried in some of our projects
(Apache Sling) and server seem to work fine.
was (Author: chetanm):
[patch|^FELIX-4550.patch] for the same. Following are some key points wrt patch
* Upgrade Jetty to 9.2.1.v20140609
* Changed the source and target compiler settings for jetty module to 1.7
* Updated the Servlet API to tomcat-servlet-api:8.0.9 to include 3.1. The
org.apache.felix.http.servlet-api bundle now also export Servlet API at 3.1
* Some classes which implement servlet api modified to support new method
** SSLFilterResponseTest
** ServletContextImpl
** ServletContextImplTest
* FilterHandler - Had to change the if condition in doHandle as by default
jetty does not set status to 200 at start
([commit|http://dev.eclipse.org/mhonarc/lists/jetty-commit/msg05356.html]).
Upto Jetty 8.x this was set to 200 at start of request itself but now it is
being set at time of commit
* JettyService - The way jetty get configured now change quite a bit. Most of
the previous config are mapped to new methods. One thing left out was support
JMX registration
*Non Compatible Change*
* Jetty 9 requires JDK 7
* ConnectorFactory - Need to change the method createConnector() to
createConnector(Server) as all Connector now require Server as part of
Constructor argument. Anyways as the Connector classes itself have changed in
non compatible way existing impls would not work
With this patch all existing test case pass. Also tried in some of our projects
(Apache Sling) and server seem to work fine.
> Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
> -----------------------------------------------------------
>
> Key: FELIX-4550
> URL: https://issues.apache.org/jira/browse/FELIX-4550
> Project: Felix
> Issue Type: New Feature
> Components: HTTP Service
> Reporter: Chetan Mehrotra
> Attachments: FELIX-4550.patch
>
>
> Currently HTTP Service embeds Jetty 8.1.14.v20131031 which supports Servlet
> 3.0. Current Jetty version 9.2.1.v20140609 supports Servlet 3.1 which
> provided access to some new NIO based features. Further it also provides lots
> of new features like Spdy support , Websocket support etc [1]
> [1] https://webtide.com/jetty-9-features/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
