[ 
https://issues.apache.org/jira/browse/FELIX-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234732#comment-14234732
 ] 

Stefan Seifert edited comment on FELIX-4550 at 12/4/14 10:39 PM:
-----------------------------------------------------------------

attached is an updated version of the patch: [^141204_FELIX-4550_jetty9.patch]

changes additionally to the previous patch:
- updated to jetty 9.2.5.v20141112
- updated all http maven modules via parent pom to JDK 1.7 (not only the jetty 
bundle itself, other bundles depend on jetty thus JDK 1.7 as well)
- updated parent pom to servlet 3.1
- re-enabled the configuration option for enabling/disabling JMX stats 
publishing and validated that it's working
- removed the commented out "sendServerHeader" code after validation that the 
new code in configureHttpConnectionFactory works properly
- removed the configuration options org.apache.felix.http.nio and 
org.apache.felix.https.nio because the ServerConnector from Jetty 9 always uses 
NIO
- switched println calls in one integration test to print("...\n") because the 
other variant failed on windows (i assume platform-dependent new-line)

---

i did not change yet the versions of the poms itself, although it was aggreed 
to raise them to the next major version. i'm not sure how to proceed best here 
- the felix.http.* poms use different version schemes - most use 2.3.x, others 
a single version number, others numbers like 1.0.x or 0.2.x.

when you want to create a branch all of them have to be raised to the next 
major version - which does not work e.g. for the parent pom which has only a 
single version number. perhaps all poms including the parent pom should be 
raised to 3.0.x, to make sure there are no clashes if poms from the old 2.x 
branch for JDK versions < 1.7 are released.


was (Author: sseif...@pro-vision.de):
attached is an updated version of the patch: [^141204_FELIX-4550_jetty9.patch]

changes additionally to the previous patch:
- updated to jetty 9.2.5.v20141112
- updated all http maven modules via parent pom to JDK 1.7 (not only the jetty 
bundle itself, other bundles depend on jetty thus JDK 1.7 as well)
- updated parent pom to servlet 3.1
- re-enabled the configuration option for enabling/disabling JMX stats 
publishing and validated that it's working
- removed the commented out "sendServerHeader" code after validation that the 
new code in configureHttpConnectionFactory works properly
- removed the configuration options org.apache.felix.http.nio and 
org.apache.felix.https.nio because the ServerConnector from Jetty 9 always uses 
NIO
- switched println calls in one integration test to print("...\n") because the 
other variant failed on windows (i assume platform-dependent new-line)

---

i did not change yet the versions of the poms itself, although it was aggred to 
raise them to the next major version. i'm not sure how to proceed best 
currently - the felix.http.* poms use different version schemes - most use 
2.3.x, others a single version number, others numbers like 1.0.x or 0.2.x.

when you want to create a branch all of them have to be raised to the next 
major version - which does not work e.g. for the parent pom which has only a 
single version number. perhaps all poms including the parent pom should be 
raised to 3.0.x, to make sure they are no clashes if poms from the old 2.x 
branch for JDK versions < 1.7 are released.

> Upgrade embedded Jetty to version 9.2.x in Felix Http Jetty
> -----------------------------------------------------------
>
>                 Key: FELIX-4550
>                 URL: https://issues.apache.org/jira/browse/FELIX-4550
>             Project: Felix
>          Issue Type: New Feature
>          Components: HTTP Service
>            Reporter: Chetan Mehrotra
>         Attachments: 141204_FELIX-4550_jetty9.patch, FELIX-4550.patch
>
>
> Currently HTTP Service embeds Jetty 8.1.14.v20131031 which supports Servlet 
> 3.0. Current Jetty version 9.2.1.v20140609 supports Servlet 3.1 which 
> provided access to some new NIO based features. Further it also provides lots 
> of new features like Spdy support , Websocket support etc [1]
> [1] https://webtide.com/jetty-9-features/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to