[
https://issues.apache.org/jira/browse/FELIX-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238983#comment-14238983
]
Peter Kriens commented on FELIX-4720:
-------------------------------------
a) Pinning by the framework is quite different from pinning by a bundle,
especially if the bundle is geared towards debugging. It then becomes a choice
of the bundle how to do this (i.e.they could turn the log entry exceptions that
are the pinning culprit into strings or so. The framework cannot do it.
b) The OSGi spec does not give you any guarantee about the history, so yes, you
could already lose events.
c) The bug explains why you cannot override the Equinox log service in an easy
way
d) The OSGi services are enablers, not trying to be efficient, that is up to
implementations
I do not think there is any reason to become defensive. The Equinox log is a
perfectly valid Log Service implementation that show that WebConsols & Gogo
fail a compliant implementation. Of course you can ignore this issue (and I
filed a corresponding bug on Eclipse to disable the built-in Log Service or
provide a buffer) but the fact is that WebConsole fails on a perfectly
legitimate implementation. Since it is not hat hard to fix, I would fix it.
> Web Console and Gogo rely on Log history buffer in the Log Service
> ------------------------------------------------------------------
>
> Key: FELIX-4720
> URL: https://issues.apache.org/jira/browse/FELIX-4720
> Project: Felix
> Issue Type: Bug
> Components: Gogo Command, Web Console
> Reporter: Peter Kriens
>
> The OSGi Log Reader Service has a command to get the history of the log.
> However, the specification states that this history can be empty. The Equinox
> framework is nowadays registering a Log Reader Service that has such an empty
> history to prevent pinning objects in memory.
> Using the history this way was always at odds with the specification since
> the history was only intended to hold the start up events. The primary model
> of the Log Service is a dispatcher.
> I suggest that the Gogo log command and the Web Console maintain their own
> history buffer to become independent on this fragile history buffer in the
> Log Reader service.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
