[
https://issues.apache.org/jira/browse/FELIX-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239475#comment-14239475
]
Carsten Ziegeler commented on FELIX-4720:
-----------------------------------------
I tend to agree with Peter: if a valid log service implementation can return an
empty buffer (or even if its a very small one like just the last log
statement), the web console functionality becomes useless.
Right now I see two options:
- the web console plugin could be configurable to either use the history or
keep its own buffer (using the history is an optimization). Gogo could do
similar
- we could provide an inventory printer doing the buffering and that one is
used by the web console and gogo
> Web Console and Gogo rely on Log history buffer in the Log Service
> ------------------------------------------------------------------
>
> Key: FELIX-4720
> URL: https://issues.apache.org/jira/browse/FELIX-4720
> Project: Felix
> Issue Type: Bug
> Components: Gogo Command, Web Console
> Reporter: Peter Kriens
>
> The OSGi Log Reader Service has a command to get the history of the log.
> However, the specification states that this history can be empty. The Equinox
> framework is nowadays registering a Log Reader Service that has such an empty
> history to prevent pinning objects in memory.
> Using the history this way was always at odds with the specification since
> the history was only intended to hold the start up events. The primary model
> of the Log Service is a dispatcher.
> I suggest that the Gogo log command and the Web Console maintain their own
> history buffer to become independent on this fragile history buffer in the
> Log Reader service.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
