As you can see I've made some changes based on Tom's feedback: - the exceptions are lazily created once again - the exception types are stupid simple and so cannot bleed impl details - there's javadoc on each type
Cheers, - Ray On Fri, Feb 23, 2018 at 10:59 AM, Thomas Watson <tjw...@gmail.com> wrote: > See my comments in the issue. > > Tom > > On Fri, Feb 23, 2018 at 9:16 AM, Raymond Auge <raymond.a...@liferay.com> > wrote: > > > Hello All, > > > > I'd like to get some feedback particularly from Richard Hall, Thomas > Watson > > and/or Karl Pauls regarding the change described in > > https://issues.apache.org/jira/browse/FELIX-5782 > > > > Is there any reason I cannot merge this change? I'd like to get this in > and > > call a vote for a release of the resolver next week so we can apply it to > > bnd. I'll take no feedback as not having issues if that's ok :) > > > > Sincerely, > > -- > > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> > > (@rotty3000) > > Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> > > (@Liferay) > > Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> > > (@OSGiAlliance) > > > -- *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> (@rotty3000) Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> (@Liferay) Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
