kwin commented on a change in pull request #1: FELIX-6232 - adding option to 
install parallel version of bundle
URL: https://github.com/apache/felix-dev/pull/1#discussion_r386325480
 
 

 ##########
 File path: 
webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
 ##########
 @@ -1710,6 +1718,43 @@ private String getSymbolicName( File bundleFile )
         // fall back to "not found"
         return null;
     }
+    
+    private String getBundleVersion( File bundleFile )
+    {
+        JarFile jar = null;
+        try
+        {
+            jar = new JarFile( bundleFile );
 
 Review comment:
   try with resources 
(https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to