amitjoy commented on a change in pull request #1: FELIX-6232 - adding option to
install parallel version of bundle
URL: https://github.com/apache/felix-dev/pull/1#discussion_r386368563
##########
File path:
webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
##########
@@ -1642,8 +1648,10 @@ private void installBundle( String location, File
bundleFile, int startLevel, bo
Bundle[] bundles =
BundleContextUtil.getWorkingBundleContext(this.getBundleContext()).getBundles();
for ( int i = 0; i < bundles.length; i++ )
{
+ boolean isSameBSN = (bundles[i].getSymbolicName() != null
&& bundles[i].getSymbolicName().equals( symbolicName ));
Review comment:
BSN cannot be null according to Felix implementation but according to
Javadoc, it can. I agree completely that the null check is superfluous here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
