wilx commented on code in PR #359:
URL: https://github.com/apache/felix-dev/pull/359#discussion_r1883536048


##########
log/src/main/java/org/apache/felix/log/Activator.java:
##########
@@ -54,6 +56,8 @@
  *       the historic log information. The default value is false.</dd>
  * </dl>
  */
+@Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")
+@RequireConfigurationAdmin

Review Comment:
   I have changed it to use `@Requirement` instead with the appropriate values.



##########
log/src/main/java/org/apache/felix/log/Activator.java:
##########
@@ -54,6 +56,8 @@
  *       the historic log information. The default value is false.</dd>
  * </dl>
  */
+@Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")
+@RequireConfigurationAdmin

Review Comment:
   I have changed it to use `@Requirement` with the appropriate values instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to