stbischof commented on code in PR #403:
URL: https://github.com/apache/felix-dev/pull/403#discussion_r2030052164
##########
framework/pom.xml:
##########
@@ -217,21 +217,21 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.easymock</groupId>
- <artifactId>easymock</artifactId>
- <version>2.5.2</version>
- <scope>test</scope>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.12.1</version>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
- <version>5.16.1</version>
+ <version>5.17.0</version>
<scope>test</scope>
</dependency>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.1</version>
+ <groupId>org.assertj</groupId>
Review Comment:
Because the osgi-test setup uses also assertj and has more powerful
assertions to do assertions on OSGi Framework.
https://github.com/eclipse-osgi-technology/osgi-test/tree/main/org.osgi.test.assertj.framework%2Fsrc%2Fmain%2Fjava%2Forg%2Fosgi%2Ftest%2Fassertj
I would like to use this in forther steps.
The dependencies will also come to the module because i will integrate the
OSGi tck into the test and ci Setup. That we can always can check the
dependencies against the tck live.
You can see this in an other pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
