timothyjward commented on code in PR #403:
URL: https://github.com/apache/felix-dev/pull/403#discussion_r2036868050
##########
framework/src/test/java/org/apache/felix/framework/BundleWiringImplTest.java:
##########
@@ -408,23 +380,23 @@ public void testFirstGeneratedAccessorSkipClassloading()
throws Exception
when(bundleWiring.getBundle().getFramework()).thenReturn(mockFramework);
BundleClassLoader bundleClassLoader = createBundleClassLoader(
- BundleClassLoader.class, bundleWiring);
- assertNotNull(bundleClassLoader);
+ BundleClassLoader.class, bundleWiring);
+ assertThat(bundleClassLoader).isNotNull();
try {
- bundleClassLoader.loadClass(classToBeLoaded, true);
- fail();
+ bundleClassLoader.loadClass(classToBeLoaded, true);
+ fail("");
Review Comment:
Add a message. Empty String is unhelpful.
```suggestion
fail("Class should not load");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
