timothyjward commented on code in PR #403:
URL: https://github.com/apache/felix-dev/pull/403#discussion_r2037041067


##########
framework/src/test/java/org/apache/felix/framework/EventDispatcherTest.java:
##########
@@ -106,51 +108,46 @@ public void serviceChanged(ServiceEvent arg0)
         ed.addListener(b3.getBundleContext(), ServiceListener.class, sl3, 
null);
 
         // --- make the invocation
-        ServiceReference sr = EasyMock.createNiceMock(ServiceReference.class);
-        EasyMock.expect(sr.getProperty(Constants.OBJECTCLASS)).andReturn(new 
String[]
+        ServiceReference sr = Mockito.mock(ServiceReference.class);
+        Mockito.when(sr.getProperty(Constants.OBJECTCLASS)).thenReturn(new 
String[]
             {
                 "java.lang.String"
-            }).anyTimes();
-        sr.isAssignableTo(b1, String.class.getName());
-        EasyMock.expectLastCall().andReturn(Boolean.TRUE).anyTimes();
-        sr.isAssignableTo(b2, String.class.getName());
-        EasyMock.expectLastCall().andReturn(Boolean.TRUE).anyTimes();
-        sr.isAssignableTo(b3, String.class.getName());
-        EasyMock.expectLastCall().andReturn(Boolean.TRUE).anyTimes();
-        EasyMock.replay(new Object[]
-            {
-                sr
             });
+        
+        Mockito.when(sr.isAssignableTo(b1, 
String.class.getName())).thenReturn(true);
+        Mockito.when(sr.isAssignableTo(b2, 
String.class.getName())).thenReturn(true);
+        Mockito.when(sr.isAssignableTo(b3, 
String.class.getName())).thenReturn(true);
+//        sr.isAssignableTo(b1, String.class.getName());

Review Comment:
   Delete this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to