timothyjward commented on code in PR #403:
URL: https://github.com/apache/felix-dev/pull/403#discussion_r2036960895
##########
framework/src/test/java/org/apache/felix/framework/BundleWiringImplTest.java:
##########
@@ -479,18 +451,18 @@ public void testAccessorFirstLoadFailed() throws Exception
//make sure imported and required pkgs are searched
verify(importedPkgs).values();
- verify(requiredPkgs).values();
-
- //make sure the class is added to the skip class cache
- assertEquals(getAccessorCache(bundleWiring).get(classToBeLoaded),
BundleWiringImpl.CNFE_CLASS_LOADER);
+ verify(requiredPkgs).values();
+
+ //make sure the class is added to the skip class cache
+
assertThat(getAccessorCache(bundleWiring)).containsEntry(classToBeLoaded,
BundleWiringImpl.CNFE_CLASS_LOADER);
} catch (Exception e) {
- e.printStackTrace();
- fail();
+ e.printStackTrace();
+ fail("");
Review Comment:
```suggestion
fail("An unexpected failure occurred" + e.getMessage());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
