glimmerveen commented on code in PR #486:
URL: https://github.com/apache/felix-dev/pull/486#discussion_r2990543078
##########
scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java:
##########
@@ -132,9 +133,12 @@ public class ComponentRegistry
private final ScheduledExecutorService m_componentActor;
+ private final UpdateChangeCountProperty m_updateChangeCountPropertyTask;
+
public ComponentRegistry(final ScrConfiguration scrConfiguration, final
ScrLogger logger, final ScheduledExecutorService componentActor )
{
m_configuration = scrConfiguration;
+ m_updateChangeCountPropertyTask = new
UpdateChangeCountProperty(m_configuration.serviceChangecountTimeout());
Review Comment:
I agree that a value as low as 1 makes little sense, but I think it is up to
the user/deployer to assess what works in their context. For that reason I
would go the route of interpreting the timeout with a minimum value of 1, just
to not have the logic break, and document the new behaviour of the timeout and
advising to not choose a value lower than 100.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
