tjwatson commented on code in PR #486:
URL: https://github.com/apache/felix-dev/pull/486#discussion_r2996653300
##########
scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java:
##########
@@ -132,9 +133,12 @@ public class ComponentRegistry
private final ScheduledExecutorService m_componentActor;
+ private final UpdateChangeCountProperty m_updateChangeCountPropertyTask;
+
public ComponentRegistry(final ScrConfiguration scrConfiguration, final
ScrLogger logger, final ScheduledExecutorService componentActor )
{
m_configuration = scrConfiguration;
+ m_updateChangeCountPropertyTask = new
UpdateChangeCountProperty(m_configuration.serviceChangecountTimeout());
Review Comment:
We need the changecount update to happen by default because that is required
by the specification.
Regardless, I think the PR is in a state that we can merge now. I reduced
the minimal allowed timeout to be 1 ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
