paulrutter commented on PR #566: URL: https://github.com/apache/felix-dev/pull/566#issuecomment-6015068135
Re-reviewed at 49d33b2. Removing the `setFile` store resolves both inline points, and the project's main artifact is no longer mutated. The remaining `bundleAll` code only uses the `artifact` returned by `resolveArtifact`, so nothing depended on the removed line. Thanks for confirming that dependency-tree aliased the root artifact too, and that `visited` was already identity-based. I have no further findings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
