pderop commented on PR #581: URL: https://github.com/apache/felix-dev/pull/581#issuecomment-6398983943
Hi @paulrutter, Thanks a lot for this work, and for giving me access to your fork! I have to confess something first: over the past weeks I had been working on the same thing in a local branch (moving DM from Gradle to Maven, in my case with the `bnd-maven-plugin` and the standard Maven layout), but I never announced it on the list. That was my mistake, sorry about that. Your PR covers the same ground, and I'm happy to go with it. I took some time to review the result, focusing on the released bundles (core, annotation, runtime, shell, lambda): - I built them from your branch and compared the generated manifests and jar contents with the r16 release jars: `Bundle-SymbolicName`, `Bundle-Activator`, `Export-Package` (versions and `uses:`), `Import-Package` (apart from the `aQute.bnd.*` ranges of the annotation bundle, which follow the bndlib version) and the runtime's `Provide-Capability` are identical, and the bundles contain the same classes (except the synthetic/`doPrivileged` inner classes, as expected). Nice job. - I also checked that the baseline actually works: a change in an implementation package passes, a new public method in `org.apache.felix.dm` fails with `Version increase required; detected 4.6.0, suggested 4.7.0`, and bumping the `packageinfo` makes it pass again. So please go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
