pderop commented on PR #581:
URL: https://github.com/apache/felix-dev/pull/581#issuecomment-6402189895
> Would this then become r17? I still don't fully understand how that works
together with the independent versioning of the bundles in dm. Is it just a
release name for the combination of those separate bundles?
Yes, `rN` was just a name for the set of DM bundles released (and voted)
together, each bundle keeping its own version.
Back then, we introduced a specific release process for Dependency Manager
to accommodate Bndtools. Now that we're moving back to Maven, I think it makes
sense to follow the same release process as the other Felix subprojects for
consistency. So I'd say we can drop the `r17` naming and stick to the standard
Felix release process.
If you agree, the `r17` mentions in the changelogs (e.g. *"r17 is the name
of the release as a whole"*) can then go away as well.
One more thing I noticed: `mvn clean install` (as opposed to `clean verify`,
which is what the CI runs) fails on the samples module:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install)
on project org.apache.felix.dependencymanager.samples: The packaging plugin for
this project did not assign a main file to the project but it has attachments.
Change packaging to 'pom'.
```
The `default-jar` execution is disabled and only classifier jars are
attached, so `maven-install-plugin` 3.x refuses to install the module. The same
applies to `lambda.samples` and `benchmark`. Since `release:perform` runs
`deploy`, which goes through the `install` phase, this would also break the
release (if I'm correct, I'm not sure ...).
As these modules are not released anyway, skipping the install next to the
existing deploy skip fixes it:
```xml
<properties>
<!-- the samples are not released -->
<baseline.skip>true</baseline.skip>
<maven.deploy.skip>true</maven.deploy.skip>
<maven.install.skip>true</maven.install.skip>
</properties>
```
in:
- `org.apache.felix.dependencymanager.samples/pom.xml`
- `org.apache.felix.dependencymanager.lambda.samples/pom.xml`
- `org.apache.felix.dependencymanager.benchmark/pom.xml`
With that change, `mvn --file dependencymanager/pom.xml clean install`
succeeds on your current head (`f90d9b1a78`), with all tests passing.
As I would prefer to let you keep full control of your branch, I'd rather
you push the change yourself, if you do agree with me ?
thanks Paul.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
