+1

I checked:
* The build compiles.
* The README makes sense, and the links work.
* RAT checks pass, and the configuration of RAT in the build files is
not overly permissive. (There's some room for improvement here.)
* The signature is valid on both src and binary releases.
* The release is branched and tagged in git.
* The contents of LICENSE and NOTICE make sense

I was left with questions about the different NOTICE file for the
binary release.  Are we really bundling all that stuff in our binary
release? junit? Does it really need to go into the NOTICE file?

On the whole though, it's a solid release.

Best Regards,
Myrle Krantz


On Mon, May 22, 2017 at 9:45 AM, Mexina M. Daniel <[email protected]> wrote:
> +1
>
> ----- Original Message -----
> From: "Myrle Krantz" <[email protected]>
> To: "dev" <[email protected]>
> Sent: Monday, May 22, 2017 10:10:28 AM
> Subject: Re: [VOTE] Apache Fineract 1.0.0
>
> Hey all,
>
> I may not be able to find time to check this release until the coming 
> Wednesday.
>
> With apologies,
> Myrle
>
>
> On Sat, May 20, 2017 at 10:16 AM, Ippez Robert <[email protected]> wrote:
>> +1
>>
>> On Fri, May 19, 2017 at 10:40 AM, Nazeer Shaik <[email protected]>
>> wrote:
>>
>>> Hello Fineract community,
>>>
>>> We have created first Apache Fineract 1.0.0 TLP release, with the artifacts
>>> below up for a vote.
>>>
>>> These are the goals of this release:
>>>
>>>    - Share the first TLP release to the community
>>>
>>>
>>>    - Share the new features & bugs fixes that have been developed so far,
>>>    to give the community a good sense of the upcoming 1.0.0 release
>>>
>>> *For more information including release notes, please see:*
>>> https://cwiki.apache.org/confluence/display/FINERACT/1.
>>> 0.0+-+Apache+Fineract
>>>
>>> *Source & Binary files:*
>>> https://dist.apache.org/repos/dist/dev/fineract/1.0.0/
>>> Source: https://dist.apache.org/repos/dist/dev/fineract/1.0.0/
>>> apache-fineract-1.0.0-src.tar.gz
>>> Binary/War : https://dist.apache.org/repos/dist/dev/fineract/1.0.0/
>>> apache-fineract-1.0.0-binary.tar.gz
>>>
>>> *Commit to be voted on:*
>>> https://git-wip-us.apache.org/repos/asf?p=fineract.git;a=
>>> commit;h=refs/heads/1.0.0
>>>
>>> *Source build verification steps can be found at:*
>>> Refer 'README.md' in apache-fineract-1.0.0-src.tar.gz
>>>
>>> *Binary Deployment steps can be found at:*
>>> https://cwiki.apache.org/confluence/display/FINERACT/
>>> Fineract+Installation+on+Ubuntu+Server
>>>
>>> *KEYS file containing PGP Keys we use to sign the release: (Signed using
>>> 0BB29444)*
>>> https://dist.apache.org/repos/dist/dev/fineract/KEYS
>>>
>>> Vote will be open for 72 hours.
>>>
>>> [ ] +1  approve
>>> [ ] +0  no opinion
>>> [ ] -1  disapprove (and reason why)
>>>
>>>
>>> Here's my +1
>>> Thanks,
>>> Nazeer
>>>
>>
>>
>>
>> --
>> Ippez Roberts
>> Director & Founder - Skyline Technologies Uganda
>> "IT Consultants & Engineers"
>> P.O.Box 155, Moyo
>> UGANDA.
>> Tel: +256788725408/789643284
>> Skype ID: ippez.robert1
>> Email: [email protected]

Reply via email to