On Mon, Nov 13, 2017 at 3:58 PM, Ed Cable <[email protected]> wrote: > In all fairness to Nazeer, Adi, Sander and others who were reviewing the > pull requests, they provided comments and suggested feedback on the PRs in > a timely fashion but in many cases the original contributor never replied. > > I think it speaks to hopefully an easier problem we can address by > improving communications because it's all easy for us to miss github > notifications amidst the myriad of notifications flowing through. I know we > don't want to create redundant communication flows or excessive email > traffic but perhaps there are some other bots or integrations we can tap > into which will allow communications to other channels than just the email > address. We could also make it a practice of emailing on list when there > are comments but I think that's a lot of added work, creates too much noise > on the list, and defeats purpose of using the comments thread.
Github notifications are set by default to send e-mails. No extra bots or integrations necessary. If contributors aren't responding to comments on their PR's, we need to decide if we want to do the remaining work ourselves, or if we are ready to close the PR's. We should not just leave PR's open indefinitely. The clutter accumulates and makes our project unattractive. Contributors can always create a new PR if we close a PR and then it turns out the contributor actually was still interested. Closing pull requests is not the same thing as deleting the original code. That said, I'm going to start the following: 1.) find the oldest PR 2.) If there is a committer request for changes on a PR, I'll ping via github asking if the changes will still be made. If not I'll go straight to asking on the dev list. 3.) If there is no response in 72 hours, I'll ask here if anyone wishes to merge the PR without changes or make the changes themselves. 4.) If I have no response after another 72 hours, I'll close the PR. I'm starting with this pull request: https://github.com/apache/fineract/pull/40 I'll be doing them one at a time and we have 47 open pull requests so this will take about a year. If we continue accumulating dead pull requests, I may have to parallelize. Go ahead and get your favorite PR's merged *before* I ping them. Please. Best Regards, Myrle > On Fri, Oct 20, 2017 at 2:21 AM, Myrle Krantz <[email protected]> wrote: > >> I believe at some point we're going to have to accept that the oldest >> pull requests can no longer be made useful. >> >> I've been considering closing any pull request which has not been >> commented on in the last 3 months. It's terrible, but it's more >> honest than pretending we're going to eventually get around to it. >> And closing with the comment that we just don't have the necessary >> resources to merge is more fair to the contributor than leaving them >> in limbo forever. >> >> Best regards, >> Myrle
