Hi Myrle, I'm available to update these Pull Requests in case there are any pending corrections you would love to see.
At Your Service, Isaac Kamga On Mon, Mar 5, 2018 at 10:03 PM, Isaac Kamga <isaac.ka...@mifos.org> wrote: > Hi Myrle, > > I've updated the PRs which you hadn't merged yet and have opened new ones > for the 5 repos you had merged. > > Please feel free to comment on the PRs if they're not perfect before you > merge. > > Cheers, > Isaac Kamga. > > On Mon, Mar 5, 2018 at 2:25 PM, Isaac Kamga <isaac.ka...@mifos.org> wrote: > >> Okay, >> >> I see that you've merged PRs on fineract-cn-lang, fineract-cn-api, >> fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async. >> >> Yes please, I would like to update each PR on the repositories which you >> haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... ) during >> the later parts of today to early tomorrow. >> >> Cheers, >> Isaac. >> >> On Mon, Mar 5, 2018 at 1:58 PM, Myrle Krantz <my...@apache.org> wrote: >> >>> : o) >>> >>> Did you want to do just the ones I haven't merged yet? If so, I'll >>> hold up and wait. >>> >>> Greets, >>> Myrle >>> >>> On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga <isaac.ka...@skylabase.com> >>> wrote: >>> > Hi Myrle, >>> > >>> > Thanks for taking time out to review. >>> > >>> > About those 2 last lines of code, I could update all pull requests by >>> > removing the ext.name and ext.year variables but you already started >>> > merging some... ;-). >>> > >>> > Cheers, >>> > Isaac Kamga. >>> >> >> >
