Hi Ippez, Sorry I didnt code that so thats not my code, but I am happy and willing to help out with the error. :-) It turns out that the config property is undefine thats why you get that error. So do you get the error when you try the pull request I did above or before that?
On Tue, Apr 24, 2018 at 9:02 AM, Ippez Robert <[email protected]> wrote: > Hi Courage, > Hope you are fine. > I was trying to run your codes but in developer console i get below > errors, what could be the cause? > > > > Thanks > Regards > Ippez Robert > > On Mon, Apr 23, 2018 at 11:09 PM, Courage Angeh <[email protected]> > wrote: > >> Hi Ed, >> >> I turns out the community app couldn't get notifications from the back-end >> server. I did a pull request to fix that but it wasn't merged, I have done >> a new pull request: https://github.com/openMF/community-app/pull/2937 and >> that should fix it up. >> I have updated the docuemtation as you requested, I would love to get your >> feedback on it. >> >> One question, is the demo3 server communicating with a server containing >> the enhanced notification I did? >> >> Thanks, >> Courage >> >> On Wed, Apr 11, 2018 at 8:07 AM, Courage Angeh <[email protected]> >> wrote: >> >> > Yes, I will. >> > >> > On Wed, Apr 11, 2018, 7:09 AM Ed Cable <[email protected]> wrote: >> > >> >> Courage, >> >> >> >> In that documentation could you please include the list of events that >> >> have notifications get generated for them? >> >> >> >> Thanks, >> >> >> >> Ed >> >> >> >> On Tue, Apr 10, 2018 at 6:00 PM, Ed Cable <[email protected]> wrote: >> >> >> >>> https://demo3.openmf.org >> >>> >> >>> mifos/password >> >>> >> >>> Ed >> >>> >> >>> On Tue, Apr 10, 2018 at 5:21 PM, Courage Angeh < >> [email protected]> >> >>> wrote: >> >>> >> >>>> Hi Ed, >> >>>> >> >>>> On Tue, Apr 10, 2018 at 2:19 PM, Ed Cable <[email protected]> wrote: >> >>>> >> >>>>> Courage, >> >>>>> >> >>>>> Pardon my ignorance but I still am not able to get notifications >> >>>>> working. >> >>>>> >> >>>>> I see and understand the gist of the documentation page that Adhyan >> >>>>> provided in that if you want to receive a notification that a >> savings >> >>>>> account has been *created* in order to take the action of* >> approving* >> >>>>> it, your role needs the permission to *activate *or *approve* that >> >> >>>>> saving account. >> >>>>> >> >>>> >> >>>> If you receive a notification that a savings account has been created >> >>>> then you account already has permissions to activate or approve a >> saving >> >>>> account >> >>>> >> >>>> >> >>>>> I did that configuration on the demo3 server but still no >> notification >> >>>>> is getting generated. >> >>>>> >> >>>> >> >>>> Can you send me a link to the hosted demo3 server so I can try it >> out? >> >>>> >> >>>>> >> >>>>> I also think we need to improve upon the documentation: >> >>>>> >> >>>>> 1) We need to show which actions have notifications already >> >>>>> configured. For each action, we should say: 1) What action generates >> >>>>> notification 2) what action can be taken from notification (if any) >> and 3) >> >>>>> what permission needs to be enabled for that user to view >> notification (if >> >>>>> that's how a notification is configure) >> >>>>> >> >>>> >> >>>>> 2) Is it really the case that the only configuration around the >> >>>>> notifications framework is by enabling permissions? We have no UI >> >>>>> whatsoever? If so, that should be an enhancement that we have an >> intern or >> >>>>> volunteer focus on so it's more explicit about configuring >> notifications >> >>>>> from the UI >> >>>>> >> >>>> >> >>>> The is no special UI configuration needed for a user to configure >> >>>> notification. What actually happens is; When a user selects a role, >> He/She >> >>>> is subcribed to the listen to notifications for the permissions in >> that >> >>>> role. For example, if a user has a role called Admin and Admin has >> >>>> permissions New Savings Account Approved, then when ever a new >> Savings >> >>>> account is created a notification will be sent to that user because >> >>>> Creating a new saving emitts events to notify any user have >> permissions to >> >>>> approve a new savings account >> >>>> >> >>>> >> >>>>> >> >>>>> 3) Related to that last point, where does all the work that you did >> >>>>> around subscriber groups come into play? I thought that you had made >> >>>>> enhancements to allow notifications to be generated to entire sets >> of >> >>>>> users. Is that all just on the back-end whereby a subscriber group >> to >> >>>>> receive notifications gets created whenever a new role is created? >> If so, >> >>>>> could you create/update documentation to reflect the same. >> >>>>> >> >>>> >> >>>> Most of the work I did was backend intensive. Notifications are sent >> >>>> only to the users with permissions to act on that notification. >> >>>> >> >>>> >> >>>>> >> >>>>> What I'd like to see is a piece of documentation that explains to >> >>>>> users to who, for what actions, and how notifications get generated >> and >> >>>>> then explains how to configure these and/or disable them. We also >> need to >> >>>>> make it clear how users can extend by enabling notifications for >> other >> >>>>> permissions. >> >>>>> >> >>>>> We should also link to documentation on self-service app side which >> >>>>> explains how the mobile banking app hooks into these notifications. >> >>>>> >> >>>>> Right now if I was a user I wouldn't even know notifications were >> >>>>> available and how to take advantage of this nice feature. >> >>>>> >> >>>>> Thanks, >> >>>>> >> >>>>> Ed >> >>>>> >> >>>> >> >>>> Thanks alot for your feedback Ed. I will create a detailed >> >>>> documentation explain the notification framework and how to >> configure it. >> >>>> >> >>>> Courage. >> >>>> >> >>>> >> >>>>> >> >>>>> On Tue, Apr 10, 2018 at 5:47 AM, Courage Angeh < >> [email protected] >> >>>>> > wrote: >> >>>>> >> >>>>>> Hi Ed, >> >>>>>> >> >>>>>> Most of the work I did was enhancements, and I added few other >> >>>>>> notification events. So Adhyan's documentation is still valid, I >> have made >> >>>>>> a few updates and the documentation should be okay now. >> >>>>>> >> >>>>>> Thanks, >> >>>>>> Courage >> >>>>>> >> >>>>>> On Mon, Apr 9, 2018 at 9:25 PM, Ed Cable <[email protected]> >> wrote: >> >>>>>> >> >>>>>>> Courage, >> >>>>>>> >> >>>>>>> Can you point me to the documentation for end users/sys admins to >> >>>>>>> configure the notifications framework? >> >>>>>>> >> >>>>>>> I know that Adhyan had created this documentation at >> >>>>>>> https://mifosforge.jira.com/wiki/spaces/docs/pages/ >> >>>>>>> 153387033/Configure+Notifications but I think all the work you've >> >>>>>>> done around subscriber groups recently supersedes that. >> >>>>>>> >> >>>>>>> I know you created the doc on configuration of active MQ at >> >>>>>>> https://cwiki.apache.org/confluence/display/FINERACT/ >> >>>>>>> Setting+up+ActiveMQ+for+Fineract+1.0 but i've not been able to >> find >> >>>>>>> anything else. >> >>>>>>> >> >>>>>>> With the release now out, I want to make sure users know to >> properly >> >>>>>>> configure the notifications - both enabling it, configuring >> subscriber >> >>>>>>> groups, configuring for which events notifications occur, etc. >> >>>>>>> >> >>>>>>> Thanks, >> >>>>>>> >> >>>>>>> Ed >> >>>>>>> >> >>>>>>> -- >> >>>>>>> *Ed Cable* >> >>>>>>> President/CEO, Mifos Initiative >> >>>>>>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >> >>>>>>> >> >>>>>>> *Collectively Creating a World of 3 Billion Maries | * >> >>>>>>> http://mifos.org <http://facebook.com/mifos> >> >>>>>>> <http://www.twitter.com/mifos> >> >>>>>>> >> >>>>>>> >> >>>>>> >> >>>>> >> >>>>> >> >>>>> -- >> >>>>> *Ed Cable* >> >>>>> President/CEO, Mifos Initiative >> >>>>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >> >>>>> >> >>>>> *Collectively Creating a World of 3 Billion Maries | * >> http://mifos.org >> >>>>> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >> >>>>> >> >>>>> >> >>>> >> >>> >> >>> >> >>> -- >> >>> *Ed Cable* >> >>> President/CEO, Mifos Initiative >> >>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >> >>> >> >>> *Collectively Creating a World of 3 Billion Maries | * >> http://mifos.org >> >>> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >> >>> >> >>> >> >> >> >> >> >> -- >> >> *Ed Cable* >> >> President/CEO, Mifos Initiative >> >> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >> >> >> >> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org >> >> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >> >> >> >> >> > > > > -- > Ippez Roberts > Founder/C.E.O - Swift3 Technologies (U) Ltd > "Redefining Next Generation I/O Systems" > P.O.Box 155, Moyo > UGANDA. > Tel: +256788725408/770602630 > Skype ID: ippez.robert1 > Email: [email protected] >
