Hi Mike,
One issue would be the removal of TaskInternal.execute() method in Gradle
5.x which is used in all DB related tasks (explicit call to
flywayMigrate.execute() etc).
@Juhan : While I am not sure why the readme has instructions for
downloading gradle wrapper separately (given that it is a part of the
project repo and committed into the code), Mike's pr does update the gradle
version in the checked in wrapper and should be sufficient to ensure that
all developers are using the right gradle version. What you are suggesting
is upgrading the wrapper itself, which while undoubtedly would be good to
have, probably isn't a must do for this pr given that there do not seem to
be any major changes to the features of the wrapper itself.
Details of a quick fix I attempted to work around the removed
TaskInternal.execute() method follow.
Using finalizedBy instead of execute ( i.e migrateTenantListDB.finalizedBy
flywayMigrate) led to the error "Could not get unknown property
'classesDir' for integration test classes of type
org.gradle.api.internal.tasks.DefaultSourceSetOutput". This was fixed by
upgrading flyway plugin to.
apply plugin: 'org.flywaydb.flyway'
dependencies {
classpath
"gradle.plugin.com.boxfuse.client:gradle-plugin-publishing:5.2.4"
}
}
However, this does not seem to work with the current drizzle driver on the
classpath (results in the error "MySQL upgrade required: MySQL 0.1 is
outdated and no longer supported by Flyway. Flyway currently supports MySQL
5.1 and newer"). It runs without issues if I swap in a MySQL driver though.
Regards,
Vishwas
On Mon, Feb 18, 2019 at 1:41 AM Juhan Aasaru <[email protected]> wrote:
> Hello Mike!
>
> That is a great initiative. I checked the pull request and I noticed
> something that you might want to take into account.
>
> Currently, Readme.md has instructions on how to download Gradle Wrapper.
> In my understanding, the correct Gradle Wrapper should be already committed
> to the code and the
> developers shouldn't need to download the Wrapper. This is the whole idea
> behind using Gradle Wrapper
> so that everybody uses the same Gradle version.
>
> I see that the old wrapper is still there under
> /fineract-provider/gradle/wrapper
> and your pull request doesn't touch that.
>
> I think the issue could be solved by:
> 1. run gradle wrapper
> 2. include the changed files (/fineract-provider/gradle/wrapper) in your
> pull request
> 3. update Readme.md and remove the instructions about needing to download
> Gradle Wrapper.
>
> I didn't try it out myself so it might need some changes but I hope you get
> the idea.
>
> Kind regards,
> Juhan
>
>
>
>
> Kontakt Michael Vorburger (<[email protected]>) kirjutas kuupäeval E, 18.
> veebruar 2019 kell 01:51:
>
> > Hello,
> >
> > I would like to propose https://github.com/apache/fineract/pull/525 to
> > upgrade the Gradle version used in Fineract.
> >
> > It would be good to get some reviews and perhaps manual testing from some
> > people. I does of course build again (see the "green" PR, now that we
> have
> > Travis CI integration), but I have not done any testing of it... would
> > someone like pull it, build it, fire it up and give it a try to make
> sure I
> > didn't break anything?
> >
> > Please see https://issues.apache.org/jira/browse/FINERACT-700 for the
> full
> > details of the work that was required and done.
> >
> > I'll self merge this in 2 weeks if I don't hear any objections from
> anyone.
> >
> > Regards,
> > Michael
> >
> > PS: I'm not actually reading this list (and won't, just due to general
> > load), but am replying to this via web interface; please Reply-To-All if
> > you want me to see replies.
> > _______________________
> > Michael Vorburger
> > http://www.vorburger.ch
> >
>
