Hi! Vishwas and Myrle, thanks for explanations regarding Gradle version and wrapper download instructions. I first didn't notice that Michael had changed Gradle version inside gradle-wrapper.properties Instructions regarding downloading wrapper could include a line: "You only need to download wrapper if file fineract-provider/gradle/wrapper/gradle-wrapper.jar doesn't already exist"
I had problems with Gradle when I first imported the project. I think some of the confusion was caused by the fact that root directory contains gradlew and gradlew.bat but the wrapper is inside fineract-provider/gradle/wrapper When I imported the project into IntelliJ IDEA it auto-generated following files: <root>/gradle/wrapper/gradle-wrapper.jar <root>/gradle/wrapper/gradle-wrapper.properties <root>/fineract-provider/gradlew <root>/fineract-provider/gradlew.bat This is caused by the fact that the actual root directory of Gradle project is fineract-provider My proposition would be to include separate gradlew and gradlew.bat in fineract-provider directory (to avoid them being auto generated or considered missing). Or completely move them from root to fineract-provider. Kind regards Juhan Kontakt Myrle Krantz (<[email protected]>) kirjutas kuupäeval E, 18. veebruar 2019 kell 22:59: > On Mon, Feb 18, 2019 at 8:39 PM Vishwas Babu < > [email protected]> wrote: > > > @Juhan : While I am not sure why the readme has instructions for > > downloading gradle wrapper separately (given that it is a part of the > > project repo and committed into the code), > > > > ASF policy is that releases should not include binaries. That includes the > gradle.jar. So before a release is cut the gradle jar is deleted. Many > developers work from forks. We include the gradlel jar for them. But we > don't want two versions of the readme. That makes it necessary to download > the gradle wrapper or install gradle locally, and necessary to include that > in the instructions. > > Best Regards, > Myrle >
