Hello Everyone,

Hope this email finds you in good health.

I have started upgrading fims web-app from angular v4 to v7 to solve the
errors I faced when writing unit test. Here,
https://issues.apache.org/jira/browse/FINCN-102

I have created a Jira ticket :
https://issues.apache.org/jira/browse/FINCN-154 to keep track.
Here, is the link to my github repository :
https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade
with the new branch I created to contain the upgrade.

Can a new branch be created on the Apache repository for me to push the
changes there so as to enable other people to contribute?

Right now, am facing some errors with ngrx and here is the link to the
paste bin containing  the errors : https://pastebin.com/uvZLCwy5.

Please, Mark can you help with the errors above?

Thanks
Ruphine Kengne
ERROR in node_modules/@ngx-translate/core/src/translate.service.d.ts(1,24): 
error TS2305: Module '"../../../@angular/core/core"' has no exported member 
'OpaqueToken'.
src/app/accounting/accounts/account.detail.component.ts(57,34): error TS2339: 
Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/accounting/store/account/effects/route.effects.ts(33,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/account/effects/route.effects.ts(39,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/account/effects/route.effects.ts(45,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/account/task/effects/route.effects.ts(33,28): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/index.ts(99,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/accounting/store/ledger/effects/route.effects.ts(32,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/effects/route.effects.ts(38,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/journal-entry/effects/route.effects.ts(33,26): 
error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/transaction-type/effects/route.effects.ts(33,26):
 error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/ledger/transaction-type/effects/route.effects.ts(39,26):
 error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/accounting/store/payroll/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/common/date/fims-date.pipe.ts(27,14): error TS2415: Class 
'DisplayFimsDate' incorrectly extends base class 'DatePipe'.
  Types have separate declarations of a private property 'locale'.
src/app/common/store/form.reducer.ts(37,25): error TS2339: Property 'payload' 
does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(71,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(89,32): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(94,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(107,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/resource.reducer.ts(120,35): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/common/store/search.reducer.ts(63,51): error TS2339: Property 'payload' 
does not exist on type 'Action'.
src/app/common/store/search.reducer.ts(73,51): error TS2339: Property 'payload' 
does not exist on type 'Action'.
src/app/customers/cases/case.detail.component.ts(48,49): error TS2345: Argument 
of type '{}' is not assignable to parameter of type 'FimsPermission[]'.
  Type '{}' is missing the following properties from type 'FimsPermission[]': 
length, pop, push, concat, and 25 more.
src/app/customers/cases/case.detail.component.ts(51,8): error TS2339: Property 
'map' does not exist on type 'OperatorFunction<{} | FimsCase, { hasPermission: 
any; isCreatedOrPending: boolean; }>'.
src/app/customers/cases/case.list.component.ts(79,49): error TS2345: Argument 
of type '{}' is not assignable to parameter of type 'FimsPermission[]'.
src/app/customers/cases/case.list.component.ts(82,8): error TS2339: Property 
'map' does not exist on type 'OperatorFunction<any, { hasPermission: any; 
isCustomerActive: boolean; }>'.
src/app/customers/cases/store/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/cases/store/effects/route.effects.ts(39,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/cases/store/index.ts(74,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/customers/deposits/store/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/deposits/store/effects/route.effects.ts(39,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/deposits/store/effects/service.effects.ts(37,28): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/customers/deposits/store/index.ts(47,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/customers/detail/identityCard/identity-card.detail.component.ts(63,8): 
error TS2339: Property 'do' does not exist on type 'OperatorFunction<{}, { 
identificationCard: {}; customer: any; }>'.
src/app/customers/store/catalogs/effects/route.effects.ts(33,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/store/catalogs/effects/route.effects.ts(39,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/store/catalogs/effects/route.effects.ts(45,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/store/catalogs/effects/route.effects.ts(51,28): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/store/customerTasks/effects/route.effects.ts(33,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/customers/store/effects/route.effects.ts(33,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/customers/store/identityCards/effects/route.effects.ts(32,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/customers/store/identityCards/effects/route.effects.ts(38,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/customers/store/identityCards/scans/effects/route.effects.ts(33,26): 
error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/customers/store/index.ts(76,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/customers/store/payroll/effects/route.effects.ts(32,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/customers/store/tasks/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/depositAccount/detail/deposit-product.detail.component.ts(74,47): error 
TS2339: Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/depositAccount/store/dividends/effects/route.effects.ts(33,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/depositAccount/store/dividends/effects/service.effects.ts(34,70): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/depositAccount/store/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/depositAccount/store/effects/route.effects.ts(39,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/depositAccount/store/index.ts(55,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/employees/form/edit/edit.form.component.ts(45,32): error TS2339: 
Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/employees/store/effects/route.effects.ts(33,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/employees/store/effects/route.effects.ts(39,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/employees/store/index.ts(49,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/groups/store/definition/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/groups/store/effects/route.effects.ts(33,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/groups/store/groupTasks/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/groups/store/index.ts(68,12): error TS2339: Property 'replaceReducer' 
does not exist on type 'Store<State>'.
src/app/groups/store/meeting/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/loans/products/product.detail.component.ts(56,32): error TS2339: 
Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/loans/products/product.detail.component.ts(65,34): error TS2339: 
Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/loans/products/store/charges/effects/route.effects.ts(33,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/charges/effects/route.effects.ts(39,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/effects/route.effects.ts(39,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/effects/service.effects.ts(33,3): error TS2322: 
Type 'Observable<{}>' is not assignable to type 'Observable<Action>'.
  Property 'type' is missing in type '{}' but required in type 'Action'.
src/app/loans/products/store/effects/service.effects.ts(40,58): error TS2559: 
Type 'SelectResourcePayload' has no properties in common with type 
'FetchRequest'.
src/app/loans/products/store/effects/service.effects.ts(44,51): error TS2339: 
Property 'elements' does not exist on type '{}'.
src/app/loans/products/store/effects/service.effects.ts(45,38): error TS2339: 
Property 'totalElements' does not exist on type '{}'.
src/app/loans/products/store/effects/service.effects.ts(46,35): error TS2339: 
Property 'totalPages' does not exist on type '{}'.
src/app/loans/products/store/index.ts(75,12): error TS2339: Property 
'replaceReducer' does not exist on type 'Store<State>'.
src/app/loans/products/store/lossProvision/effects/route.effects.ts(33,26): 
error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/ranges/effects/route.effects.ts(33,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/ranges/effects/route.effects.ts(39,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/tasks/effects/route.effects.ts(33,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/loans/products/store/tasks/effects/route.effects.ts(39,26): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/offices/detail/office.detail.component.ts(69,49): error TS2345: 
Argument of type '{}' is not assignable to parameter of type 'FimsPermission[]'.
src/app/offices/detail/office.detail.component.ts(72,8): error TS2339: Property 
'map' does not exist on type 'OperatorFunction<{} | Office, { hasPermission: 
any; noExternalReferences: boolean; }>'.
src/app/offices/detail/teller/detail/balance/balance.component.ts(48,7): error 
TS2339: Property 'switchMap' does not exist on type 'OperatorFunction<{}, { 
teller: {}; office: any; }>'.
src/app/offices/detail/teller/detail/denomination/denomination.list.component.ts(66,7):
 error TS2339: Property 'map' does not exist on type 'OperatorFunction<{}, { 
office: {}; teller: any; }>'.
src/app/offices/detail/teller/detail/denomination/form/create.form.component.ts(51,11):
 error TS2339: Property 'map' does not exist on type 'OperatorFunction<{}, { 
office: {}; teller: any; }>'.
src/app/offices/store/effects/route.effects.ts(33,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/offices/store/effects/route.effects.ts(45,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/offices/store/effects/route.effects.ts(51,28): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/offices/store/index.ts(57,12): error TS2339: Property 'replaceReducer' 
does not exist on type 'Store<State>'.
src/app/offices/store/teller/denomination/effects/route.effects.ts(33,26): 
error TS2339: Property 'payload' does not exist on type 'Action'.
src/app/offices/store/teller/effects/notification.effects.ts(51,28): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/offices/store/teller/effects/notification.effects.ts(63,28): error 
TS2339: Property 'payload' does not exist on type 'Action'.
src/app/offices/store/teller/effects/route.effects.ts(33,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/offices/store/teller/effects/route.effects.ts(41,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/reporting/detail/queryParams/between/between.component.ts(90,7): error 
TS2339: Property 'filter' does not exist on type 'OperatorFunction<{}, { start: 
{}; end: any; }>'.
src/app/roles/detail/role.detail.component.ts(57,40): error TS2339: Property 
'combineLatest' does not exist on type 'typeof Observable'.
src/app/roles/store/effects/route.effects.ts(33,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/roles/store/effects/route.effects.ts(39,26): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/roles/store/index.ts(41,12): error TS2339: Property 'replaceReducer' 
does not exist on type 'Store<State>'.
src/app/teller/customer/transaction/deposit/create.form.component.ts(73,41): 
error TS2339: Property 'combineLatest' does not exist on type 'typeof 
Observable'.
src/app/teller/services/available-actions.service.ts(56,23): error TS2339: 
Property 'combineLatest' does not exist on type 'typeof Observable'.
src/app/teller/store/effects/notification.effects.ts(49,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/teller/store/effects/notification.effects.ts(61,26): error TS2339: 
Property 'payload' does not exist on type 'Action'.
src/app/teller/store/effects/route.effects.ts(45,28): error TS2339: Property 
'payload' does not exist on type 'Action'.
src/app/teller/store/index.ts(53,12): error TS2339: Property 'replaceReducer' 
does not exist on type 'Store<State>'.

Reply via email to