Hello Ruphine, Done!
Regards, Vishwas On Mon, May 27, 2019 at 2:39 AM Ruphine Kengne <[email protected]> wrote: > Hello Vishwas, > > I have added some commits to this PR > <https://github.com/apache/fineract-cn-fims-web-app/pull/15> which > reduces some of the errors I faced and upgraded the ngrx to v7. > Please can you merged that to the FINCN-154 branch you created so that > anyone can clone that branch to contribute. > > Thanks. > > On Tue, 7 May 2019 at 19:48, Ruphine Kengne <[email protected]> > wrote: > >> Thanks Vishwas >> >> On Tue, 7 May 2019 at 17:23, Vishwas Babu < >> [email protected]> wrote: >> >>> Hello Ruphine, >>> >>> >>Can a new branch be created on the Apache repository for me to push >>> the changes there so as to enable other people to contribute? >>> Done, https://github.com/apache/fineract-cn-fims-web-app/tree/FINCN-154 >>> . >>> >>> Regards, >>> Vishwas >>> >>> >>> >>> On Tue, May 7, 2019 at 6:52 AM Ruphine Kengne <[email protected]> >>> wrote: >>> >>>> Hello Everyone, >>>> >>>> Hope this email finds you in good health. >>>> >>>> I have started upgrading fims web-app from angular v4 to v7 to solve >>>> the errors I faced when writing unit test. Here, >>>> https://issues.apache.org/jira/browse/FINCN-102 >>>> >>>> I have created a Jira ticket : >>>> https://issues.apache.org/jira/browse/FINCN-154 to keep track. >>>> Here, is the link to my github repository : >>>> https://github.com/kengneruphine/fineract-cn-fims-web-app/tree/angular-7-upgrade >>>> with the new branch I created to contain the upgrade. >>>> >>>> Can a new branch be created on the Apache repository for me to push the >>>> changes there so as to enable other people to contribute? >>>> >>>> Right now, am facing some errors with ngrx and here is the link to the >>>> paste bin containing the errors : https://pastebin.com/uvZLCwy5. >>>> >>>> Please, Mark can you help with the errors above? >>>> >>>> Thanks >>>> Ruphine Kengne >>>> >>>>
