Can we also understand why this code change was accepted and shipped? We should have some basic qa. Votes in release should be based on review IMHO. Thanks
On Thu, May 9, 2019, 1:22 PM Vishwas Babu <[email protected]> wrote: > Hi Abhay, > > The commit > https://github.com/apache/fineract/commit/eb5ad448fa6cb365dad7e2691f4c6f7e9bb1c196 > was > causing the CORS preflight request to fail. I have now reverted the same > and you should be able to work with the latest develop branch or > https://github.com/apache/fineract/commits/1.3.1 > > @ Santosh: The latest fineract release (1.3.0) which ships this change is > broken, can you please start the process for shipping a patch release with > the newly created branch at > https://github.com/apache/fineract/commits/1.3.1 (created from 1.3 > branch with the pr for reverting > https://github.com/apache/fineract/commit/eb5ad448fa6cb365dad7e2691f4c6f7e9bb1c196 > cherry-picked) > > Regards, > Vishwas > > > > On Thu, May 9, 2019 at 2:48 AM Abhay Chawla <[email protected]> > wrote: > >> Hi Vishwas, >> >> Could you please help us figure out the issue and resolve the same? I am >> not very much familiar with the backend code. >> >> Thanks, >> Abhay. >> >> On Thu, May 9, 2019 at 2:11 PM Santosh Math < >> [email protected]> wrote: >> >>> +vishwas <[email protected]> >>> >>> Hi Abhay, >>> >>> Yes, we have updated staging/mobile with latest code from Fineract >>> develop branch. At least 10 PRs are merged in Fineract branch since March >>> 15(last update of staging) out of which one of them may be causing you the >>> error. Here are the PRs which were merged : >>> >>> >>> https://github.com/apache/fineract/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed >>> >>> >>> On Thu, May 9, 2019 at 1:48 PM Abhay Chawla <[email protected]> >>> wrote: >>> >>>> @Santosh Math <[email protected]> has there been some >>>> change in the latest deployment of the staging and mobile server for the >>>> latest release? We are unable to send cross-origin requests as the header >>>> is no longer present in the response due to which we cannot use it for >>>> development. Could you please assist? >>>> Headers are present in the demo server but it frequently becomes >>>> inaccessible. >>>> >>>> On Thu, May 9, 2019 at 12:36 PM Abhay Chawla <[email protected]> >>>> wrote: >>>> >>>>> Adding to the discussion. +Jivjyot Singh <[email protected]> >>>>> >>>>> On Wed, May 8, 2019 at 11:19 PM Abhay Chawla <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Chirag/Ed/Sampath/Santosh/Nayan, >>>>>> >>>>>> I rechecked and now I have started to face the same issue. I verified >>>>>> that we are getting the required headers within the demo server only now, >>>>>> it seems like there has been some change with the staging/mobile servers. >>>>>> >>>>>> Ed/Santosh/Sampath/Nayan has there been any change within the >>>>>> configurations of the staging and mobile servers in the past few days? >>>>>> Earlier we had these headers and we were able to send cross-origin >>>>>> requests >>>>>> but now they seem to be absent in these servers and that is why it has >>>>>> become inaccessible. Could you please assist? >>>>>> >>>>>> Also, if possible we should work on stabilizing the demo server >>>>>> before the coding period. >>>>>> >>>>>> Thanks >>>>>> Abhay. >>>>>> >>>>>> On Wed, May 8, 2019 at 9:54 PM Chirag Gupta < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Abhay and all, >>>>>>> >>>>>>> I checked the response headers coming from both the servers (staging >>>>>>> and mobile) and I am quite sure that above-mentioned header isn't being >>>>>>> passed. As of now, I am using the demo server but it is highly unstable. >>>>>>> >>>>>>> I am not sure what possible mistake could be there in my system. >>>>>>> Could you or anyone please point me in the right direction? >>>>>>> >>>>>>> Chirag >>>>>>> >>>>>>> On Wed, May 8, 2019 at 9:42 PM Abhay Chawla < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Chirag, >>>>>>>> >>>>>>>> I am pretty sure it is already being passed otherwise it wouldn't >>>>>>>> have worked at all. Please check and ensure there is no issue within >>>>>>>> your >>>>>>>> system. >>>>>>>> >>>>>>>> Abhay. >>>>>>>> >>>>>>>> On Tue, May 7, 2019 at 3:46 PM Chirag Gupta < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hello all, >>>>>>>>> >>>>>>>>> I have done some research on the same and found that the server >>>>>>>>> needs to pass a header (Access-Control-Allow-Origin: *) in order to >>>>>>>>> solve >>>>>>>>> this problem. I hope anyone from the backend team would be able to do >>>>>>>>> it. >>>>>>>>> >>>>>>>>> If possible, please do it on both staging and mobile server. >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> Chirag Gupta >>>>>>>>> >>>>>>>>> On Sat, May 4, 2019 at 1:17 AM Ed Cable <[email protected]> wrote: >>>>>>>>> >>>>>>>>>> @Nayan Ambali <[email protected]> it doesn't appear the >>>>>>>>>> optimizations we made to the demo server have been helpful? Can you >>>>>>>>>> please >>>>>>>>>> look into it as we're continually having downtime. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> >>>>>>>>>> Ed >>>>>>>>>> >>>>>>>>>> On Fri, May 3, 2019 at 8:38 AM Abhay Chawla < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Chirag, >>>>>>>>>>> >>>>>>>>>>> A chrome extension won't solve this problem. CORS headers are >>>>>>>>>>> configured from the backend. I am able to access the staging server >>>>>>>>>>> without >>>>>>>>>>> facing any issues. Make sure you aren't doing something wrong. >>>>>>>>>>> >>>>>>>>>>> Ed/Sampath/Santosh, >>>>>>>>>>> >>>>>>>>>>> We have been facing issues with the demo server for quite some >>>>>>>>>>> time. Is it possible to fix it? >>>>>>>>>>> >>>>>>>>>>> Abhay. >>>>>>>>>>> >>>>>>>>>>> On Wed, May 1, 2019 at 1:44 PM Chirag Gupta < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Adding more people on the loop. >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Apr 29, 2019 at 2:09 PM Sampath Kumar G < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Sorry, I'm not much aware of them. Adding our developer to the >>>>>>>>>>>>> loop. >>>>>>>>>>>>> >>>>>>>>>>>>> +Shruthi M R <[email protected]> >>>>>>>>>>>>> +Santosh Math <[email protected]> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Regards, >>>>>>>>>>>>> *Sampath Kumar* >>>>>>>>>>>>> www.finflux.co | Banking Made Easy >>>>>>>>>>>>> [image: https://www.facebook.com/finflux/] >>>>>>>>>>>>> <https://www.facebook.com/finflux/> <https://www.finflux.co/> >>>>>>>>>>>>> <https://www.linkedin.com/company/finfluxtoo/> [image: >>>>>>>>>>>>> https://twitter.com/finflux_?lang=en] >>>>>>>>>>>>> <https://twitter.com/finflux_?lang=en> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Disclaimer: The information contained in this e-mail message >>>>>>>>>>>>> and any files/attachment transmitted with it is confidential and >>>>>>>>>>>>> for the >>>>>>>>>>>>> sole use of the intended recipient(s) or entity identified. If >>>>>>>>>>>>> you are not >>>>>>>>>>>>> the intended recipient, please email: >>>>>>>>>>>>> [email protected] and destroy/delete all copies >>>>>>>>>>>>> and attachment thereto along with the original message. Any >>>>>>>>>>>>> unauthorized >>>>>>>>>>>>> review, use, disclosure, dissemination, forwarding, printing or >>>>>>>>>>>>> copying of >>>>>>>>>>>>> this email or any action taken in reliance on this e-mail is >>>>>>>>>>>>> strictly >>>>>>>>>>>>> prohibited and is unlawful. The recipient acknowledges that >>>>>>>>>>>>> Conflux >>>>>>>>>>>>> Technologies Private Limited or its subsidiaries and associated >>>>>>>>>>>>> companies >>>>>>>>>>>>> are unable to exercise control or ensure or guarantee the >>>>>>>>>>>>> integrity of/over >>>>>>>>>>>>> the contents of the information contained in e-mail >>>>>>>>>>>>> transmissions. Before >>>>>>>>>>>>> opening any attachments, please check. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Mon, Apr 29, 2019 at 1:48 PM Chirag Gupta < >>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hello, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I am working on the web-app and when I call API requests from >>>>>>>>>>>>>> it, it gives me CORS error. I tried one chrome extension which >>>>>>>>>>>>>> adds the >>>>>>>>>>>>>> required header to solve the problem but then the API doesn't >>>>>>>>>>>>>> return >>>>>>>>>>>>>> anything. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Any pointers on how to fix this? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Chirag >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Ed Cable* >>>>>>>>>> President/CEO, Mifos Initiative >>>>>>>>>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >>>>>>>>>> >>>>>>>>>> *Collectively Creating a World of 3 Billion Maries | * >>>>>>>>>> http://mifos.org <http://facebook.com/mifos> >>>>>>>>>> <http://www.twitter.com/mifos> >>>>>>>>>> >>>>>>>>>> >>> >>> -- >>> Thanks & Regards >>> >>> Santosh Math >>> >>> *QA Engineer* >>> >>> *Conflux Technologies Pvt Ltd <http://www.confluxtechnologies.com/>* >>> | *Office*: +91-080-41208662 | >>> >>> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block, >>> Bengaluru, Karnataka, 560043 INDIA >>> >>
