+1 (Binding) I reviewed the ticket, and glanced at the code Diff. It looks good to me (LGTM). I did not review at a deep level and I did not run tests.
On Mon, Nov 28, 2022 at 6:16 PM Ernesto J. Olivares Mena <[email protected]> wrote: > +1 > > Ernesto Olivares M. > PM Specialist and IT Advisor > Skype Id: olivaresmena > Claro: (505) 88361252 > PMI Member ID: 1875208 > > > > On Monday, November 28, 2022 at 09:12:14 PM EST, Manoj VM < > [email protected]> wrote: > > > +1 > > On Tue, 29 Nov, 2022, 02:10 Bruce, <[email protected]> wrote: > > +1 > > On Mon, Nov 28, 2022, 11:34 PM Aleksandar Vidakovic < > [email protected]> wrote: > > +1 (binding) > > On Mon, Nov 28, 2022 at 8:06 PM Ed Cable <[email protected]> wrote: > > +1 binding. > > On Mon, Nov 28, 2022 at 11:04 AM Aleksandar Vidakovic <[email protected]> > wrote: > > Hello everyone, > > ... we have created Apache Fineract 1.8.2 release, with the artifacts > below up for a vote. > > It fixes the following issues: > https://cwiki.apache.org/confluence/display/FINERACT/1.8.2+-+Apache+Fineract > > Source & Binary files : > https://dist.apache.org/repos/dist/dev/fineract/1.8.2/ > > Tag to be voted on (rc#): > https://gitbox.apache.org/repos/asf?p=fineract.git;a=commit;h=refs/heads/1.8.2 > > Fineract's KEYS containing the PGP key we used to sign the release: > https://dist.apache.org/repos/dist/dev/fineract/KEYS > > Note that this release contains source and binary artifacts. > > This vote will be open for 72 hours: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Cheers, > > Aleksandar Vidakovic > > > > -- > *Ed Cable* > President/CEO, Mifos Initiative > [email protected] | Skype: edcable | Mobile: +1.484.477.8649 > > *Collectively Creating a World of 3 Billion Maries | *http://mifos.org > <http://facebook.com/mifos> <http://www.twitter.com/mifos> > >
