Hi Piotr, Thank you very much for raising these issues and the fixing PRs.
Regards, Adam S > On Oct 5, 2026, at 2:08 PM, Piotr Wargulak via dev <[email protected]> > wrote: > > Hi all, > > We've been adapting Fineract for a client's lending products, mostly > progressive loans, charges, and undo/replay functionality. Along the way we > found a few problems that don't look specific to our setup. > > We fixed them on our fork and opened pull requests upstream: > - FINERACT-2895 (#6575): after a reverse-replay, a waiver on the same day > loses its link to the charge, so the waiver can't be undone afterwards. > - FINERACT-2896 (#6578): adds an optional transactionDate to ?command=waive, > so a waiver can be dated. > - FINERACT-2897 (#6580): makes processPaymentAllocation and Balances > protected, so the advanced allocation processor can be extended instead of > copied. > - FINERACT-2898 (#6581): makes the order of charges that fall due on the same > day deterministic. > - FINERACT-2899 (#6584): adjust now rejects a WAIVE_CHARGES transaction and > points to undo-waive. Today it returns 200 but leaves the charge waived. > > We'd appreciate it if someone could approve these and let us know if any of > them should be handled differently. > > Best regards, > Piotr Wargulak > SolDevelo > > > SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com <http://www.soldevelo.com/> > Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland > Phone: +48 58 782 45 40 <> / Fax: +48 58 782 45 41 <>
